Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the editor 15.6.241 #23943

Merged
merged 13 commits into from Jan 5, 2018
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 13 additions & 13 deletions build/Targets/Packages.props
Expand Up @@ -66,30 +66,29 @@
<MicrosoftNuGetBuildTasksVersion>0.1.0</MicrosoftNuGetBuildTasksVersion>
<MicrosoftPortableTargetsVersion>0.1.2-dev</MicrosoftPortableTargetsVersion>
<MicrosoftServiceHubClientVersion>1.1.122-rc</MicrosoftServiceHubClientVersion>
<MicrosoftTplDataflowVersion>4.5.24</MicrosoftTplDataflowVersion>
<MicrosoftVisualBasicVersion>10.1.0</MicrosoftVisualBasicVersion>
<MicrosoftVisualStudioCallHierarchyPackageDefinitionsVersion>15.0.26730-alpha</MicrosoftVisualStudioCallHierarchyPackageDefinitionsVersion>
<MicrosoftVisualStudioCodeAnalysisSdkUIVersion>15.0.26730-alpha</MicrosoftVisualStudioCodeAnalysisSdkUIVersion>
<MicrosoftVisualStudioComponentModelHostVersion>15.0.26730-alpha</MicrosoftVisualStudioComponentModelHostVersion>
<MicrosoftVisualStudioCompositionVersion>15.0.71</MicrosoftVisualStudioCompositionVersion>
<MicrosoftVisualStudioCoreUtilityVersion>15.6.161-preview</MicrosoftVisualStudioCoreUtilityVersion>
<MicrosoftVisualStudioCompositionVersion>15.5.23</MicrosoftVisualStudioCompositionVersion>
<MicrosoftVisualStudioCoreUtilityVersion>15.6.241-preview</MicrosoftVisualStudioCoreUtilityVersion>
Copy link
Contributor Author

@olegtk olegtk Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<MicrosoftVisualStudioDebuggerEngineVersion>15.0.26811-vsucorediag</MicrosoftVisualStudioDebuggerEngineVersion>
<MicrosoftVisualStudioDebuggerMetadataVersion>15.0.26811-vsucorediag</MicrosoftVisualStudioDebuggerMetadataVersion>
<MicrosoftVisualStudioDebuggerInterop100Version>10.0.30319</MicrosoftVisualStudioDebuggerInterop100Version>
<MicrosoftVisualStudioDesignerInterfacesVersion>1.1.4322</MicrosoftVisualStudioDesignerInterfacesVersion>
<MicrosoftVisualStudioDiagnosticsPerformanceProviderVersion>15.0.26730-alpha</MicrosoftVisualStudioDiagnosticsPerformanceProviderVersion>
<MicrosoftVisualStudioEditorVersion>15.6.161-preview</MicrosoftVisualStudioEditorVersion>
<MicrosoftVisualStudioEditorVersion>15.6.241-preview</MicrosoftVisualStudioEditorVersion>
<MicrosoftVisualStudioGraphModelVersion>15.0.26730-alpha</MicrosoftVisualStudioGraphModelVersion>
<MicrosoftVisualStudioImageCatalogVersion>15.0.26730-alpha</MicrosoftVisualStudioImageCatalogVersion>
<MicrosoftVisualStudioImagingVersion>15.0.26730-alpha</MicrosoftVisualStudioImagingVersion>
<MicrosoftVisualStudioImagingInterop140DesignTimeVersion>15.0.25726-Preview5</MicrosoftVisualStudioImagingInterop140DesignTimeVersion>
<MicrosoftVisualStudioInteractiveWindowVersion>2.0.0-rc3-61304-01</MicrosoftVisualStudioInteractiveWindowVersion>
<MicrosoftVisualStudioLanguageCallHierarchyVersion>15.3.1710.203</MicrosoftVisualStudioLanguageCallHierarchyVersion>
<MicrosoftVisualStudioLanguageIntellisenseVersion>15.6.161-preview</MicrosoftVisualStudioLanguageIntellisenseVersion>
<MicrosoftVisualStudioLanguageNavigateToInterfacesVersion>15.6.161-preview</MicrosoftVisualStudioLanguageNavigateToInterfacesVersion>
<MicrosoftVisualStudioLanguageStandardClassificationVersion>15.6.161-preview</MicrosoftVisualStudioLanguageStandardClassificationVersion>
<MicrosoftVisualStudioLanguageIntellisenseVersion>15.6.241-preview</MicrosoftVisualStudioLanguageIntellisenseVersion>
<MicrosoftVisualStudioLanguageNavigateToInterfacesVersion>15.6.241-preview</MicrosoftVisualStudioLanguageNavigateToInterfacesVersion>
<MicrosoftVisualStudioLanguageStandardClassificationVersion>15.6.241-preview</MicrosoftVisualStudioLanguageStandardClassificationVersion>
<MicrosoftVisualStudioOLEInteropVersion>7.10.6070</MicrosoftVisualStudioOLEInteropVersion>
<MicrosoftVisualStudioPlatformVSEditorVersion>15.6.161-preview</MicrosoftVisualStudioPlatformVSEditorVersion>
<MicrosoftVisualStudioPlatformVSEditorVersion>15.6.241-preview</MicrosoftVisualStudioPlatformVSEditorVersion>
<MicrosoftVisualStudioProgressionCodeSchemaVersion>15.0.26730-alpha</MicrosoftVisualStudioProgressionCodeSchemaVersion>
<MicrosoftVisualStudioProgressionCommonVersion>15.0.26730-alpha</MicrosoftVisualStudioProgressionCommonVersion>
<MicrosoftVisualStudioProgressionInterfacesVersion>15.0.26730-alpha</MicrosoftVisualStudioProgressionInterfacesVersion>
Expand All @@ -115,11 +114,11 @@
<MicrosoftVisualStudioShellInterop90Version>9.0.30729</MicrosoftVisualStudioShellInterop90Version>
<MicrosoftVisualStudioTelemetryVersion>15.0.26730-alpha</MicrosoftVisualStudioTelemetryVersion>
<MicrosoftVisualStudioTemplateWizardInterfaceVersion>8.0.0.0-alpha</MicrosoftVisualStudioTemplateWizardInterfaceVersion>
<MicrosoftVisualStudioTextDataVersion>15.6.161-preview</MicrosoftVisualStudioTextDataVersion>
<MicrosoftVisualStudioTextInternalVersion>15.6.161-preview</MicrosoftVisualStudioTextInternalVersion>
<MicrosoftVisualStudioTextLogicVersion>15.6.161-preview</MicrosoftVisualStudioTextLogicVersion>
<MicrosoftVisualStudioTextUIVersion>15.6.161-preview</MicrosoftVisualStudioTextUIVersion>
<MicrosoftVisualStudioTextUIWpfVersion>15.6.161-preview</MicrosoftVisualStudioTextUIWpfVersion>
<MicrosoftVisualStudioTextDataVersion>15.6.241-preview</MicrosoftVisualStudioTextDataVersion>
<MicrosoftVisualStudioTextInternalVersion>15.6.241-preview</MicrosoftVisualStudioTextInternalVersion>
<MicrosoftVisualStudioTextLogicVersion>15.6.241-preview</MicrosoftVisualStudioTextLogicVersion>
<MicrosoftVisualStudioTextUIVersion>15.6.241-preview</MicrosoftVisualStudioTextUIVersion>
<MicrosoftVisualStudioTextUIWpfVersion>15.6.241-preview</MicrosoftVisualStudioTextUIWpfVersion>
<MicrosoftVisualStudioTextManagerInteropVersion>7.10.6070</MicrosoftVisualStudioTextManagerInteropVersion>
<MicrosoftVisualStudioTextManagerInterop100Version>10.0.30319</MicrosoftVisualStudioTextManagerInterop100Version>
<MicrosoftVisualStudioTextManagerInterop120Version>12.0.30110</MicrosoftVisualStudioTextManagerInterop120Version>
Expand Down Expand Up @@ -212,6 +211,7 @@
<SystemTextRegularExpressionsVersion>4.3.0</SystemTextRegularExpressionsVersion>
<SystemThreadingVersion>4.3.0</SystemThreadingVersion>
<SystemThreadingTasksVersion>4.3.0</SystemThreadingTasksVersion>
<SystemThreadingTasksDataflowVersion>4.5.24</SystemThreadingTasksDataflowVersion>
<SystemThreadingTasksParallelVersion>4.3.0</SystemThreadingTasksParallelVersion>
<SystemThreadingThreadVersion>4.3.0</SystemThreadingThreadVersion>
<SystemValueTupleVersion>4.3.0</SystemValueTupleVersion>
Expand Down
Expand Up @@ -18,6 +18,7 @@
using Roslyn.Test.Utilities;
using Xunit;

#pragma warning disable CS0618 // MatchKind is obsolete
namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.NavigateTo
{
public class InteractiveNavigateToTests : AbstractNavigateToTests
Expand Down Expand Up @@ -646,3 +647,4 @@ public async Task TermSplittingTest8()
}
}
}
#pragma warning restore CS0618 // MatchKind is obsolete
2 changes: 2 additions & 0 deletions src/EditorFeatures/CSharpTest/NavigateTo/NavigateToTests.cs
Expand Up @@ -15,6 +15,7 @@
using Roslyn.Test.Utilities;
using Xunit;

#pragma warning disable CS0618 // MatchKind is obsolete
namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.NavigateTo
{
public class NavigateToTests : AbstractNavigateToTests
Expand Down Expand Up @@ -1072,3 +1073,4 @@ public void ToError(__arglist)
}
}
}
#pragma warning restore CS0618 // MatchKind is obsolete
Expand Up @@ -121,6 +121,7 @@ private async Task SearchAsyncWorker(Project project)
}
}

#pragma warning disable CS0618 // MatchKind is obsolete
private void ReportMatchResult(Project project, INavigateToSearchResult result)
{
var navigateToItem = new NavigateToItem(
Expand All @@ -146,6 +147,7 @@ private MatchKind GetMatchKind(NavigateToMatchKind matchKind)
default: return MatchKind.None;
}
}
#pragma warning restore CS0618 // MatchKind is obsolete

/// <summary>
/// Returns the name for the language used by the old Navigate To providers.
Expand Down
Expand Up @@ -9,6 +9,7 @@
using Microsoft.VisualStudio.Text;
using Microsoft.VisualStudio.Text.Editor;

#pragma warning disable CS0618 // IQuickInfo* is obsolete
namespace Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.QuickInfo.Presentation
{
internal partial class QuickInfoPresenter
Expand Down Expand Up @@ -109,3 +110,4 @@ internal void AugmentQuickInfoSession(IList<object> quickInfoContent, out ITrack
}
}
}
#pragma warning restore CS0618 // IQuickInfo* is obsolete
Expand Up @@ -5,6 +5,7 @@
using Microsoft.VisualStudio.Language.Intellisense;
using Microsoft.VisualStudio.Text;

#pragma warning disable CS0618 // IQuickInfo* is obsolete
namespace Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.QuickInfo.Presentation
{
internal partial class QuickInfoPresenter
Expand All @@ -30,3 +31,4 @@ public void Dispose()
}
}
}
#pragma warning restore CS0618 // IQuickInfo* is obsolete
Expand Up @@ -8,6 +8,7 @@
using Microsoft.VisualStudio.Text.Editor;
using Microsoft.VisualStudio.Utilities;

#pragma warning disable CS0618 // IQuickInfo* is obsolete
namespace Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.QuickInfo.Presentation
{
[Export(typeof(IQuickInfoSourceProvider))]
Expand Down Expand Up @@ -42,3 +43,4 @@ IQuickInfoSource IQuickInfoSourceProvider.TryCreateQuickInfoSource(ITextBuffer t
}
}
}
#pragma warning restore CS0618 // IQuickInfo* is obsolete
Expand Up @@ -7,6 +7,7 @@
using Microsoft.VisualStudio.Language.Intellisense;
using Microsoft.VisualStudio.Text;

#pragma warning disable CS0618 // IQuickInfo* is obsolete
namespace Microsoft.CodeAnalysis.Editor.CommandHandlers
{
internal partial class QuickInfoCommandHandlerAndSourceProvider
Expand Down Expand Up @@ -50,3 +51,4 @@ public void Dispose()
}
}
}
#pragma warning restore CS0618 // IQuickInfo* is obsolete
Expand Up @@ -16,6 +16,7 @@
using Microsoft.VisualStudio.Text;
using Microsoft.VisualStudio.Utilities;

#pragma warning disable CS0618 // IQuickInfo* is obsolete
namespace Microsoft.CodeAnalysis.Editor.CommandHandlers
{
[Export]
Expand Down Expand Up @@ -96,3 +97,4 @@ internal bool TryHandleEscapeKey(EscapeKeyCommandArgs commandArgs)
}
}
}
#pragma warning restore CS0618 // IQuickInfo* is obsolete
Expand Up @@ -16,6 +16,7 @@
using Microsoft.VisualStudio.Text.Editor;
using Roslyn.Utilities;

#pragma warning disable CS0618 // IQuickInfo* is obsolete
namespace Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.QuickInfo
{
internal partial class Controller :
Expand Down Expand Up @@ -168,3 +169,4 @@ public IList<IQuickInfoProvider> GetProviders()
}
}
}
#pragma warning restore CS0618 // IQuickInfo* is obsolete
Expand Up @@ -25,11 +25,13 @@ void ICommandHandler<InvokeQuickInfoCommandArgs>.ExecuteCommand(InvokeQuickInfoC
}
}

#pragma warning disable CS0618 // IQuickInfo* is obsolete
public void InvokeQuickInfo(int position, bool trackMouse, IQuickInfoSession augmentSession)
{
AssertIsForeground();
DismissSessionIfActive();
StartSession(position, trackMouse, augmentSession);
}
#pragma warning restore CS0618 // IQuickInfo* is obsolete
}
}
2 changes: 1 addition & 1 deletion src/EditorFeatures/Test2/EditorServicesTest2.vbproj
Expand Up @@ -65,7 +65,6 @@
but includes the lib folder so it's copied as a dependency of Microsoft.VisualStudio.Platform.VSEditor. Unfortunately we still have test code that
does depend on internal APIs, so we need to a force a reference here. -->
<Reference Include="$(NuGetPackageRoot)\microsoft.visualstudio.text.internal\$(MicrosoftVisualStudioTextInternalVersion)\lib\net46\Microsoft.VisualStudio.Text.Internal.dll" />
<PackageReference Include="Microsoft.Tpl.Dataflow" Version="$(MicrosoftTplDataflowVersion)" />
<PackageReference Include="Microsoft.VisualStudio.Composition" Version="$(MicrosoftVisualStudioCompositionVersion)" />
<PackageReference Include="Microsoft.VisualStudio.Platform.VSEditor" Version="$(MicrosoftVisualStudioPlatformVSEditorVersion)" />
<PackageReference Include="BasicUndo" Version="$(BasicUndoVersion)" />
Expand All @@ -80,6 +79,7 @@
<PackageReference Include="Microsoft.VisualStudio.Text.UI" Version="$(MicrosoftVisualStudioTextUIVersion)" />
<PackageReference Include="Microsoft.VisualStudio.Text.UI.Wpf" Version="$(MicrosoftVisualStudioTextUIWpfVersion)" />
<PackageReference Include="Microsoft.VisualStudio.Validation" Version="$(MicrosoftVisualStudioValidationVersion)" />
<PackageReference Include="System.Threading.Tasks.Dataflow" Version="$(SystemThreadingTasksDataflowVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: if this is implied by Microsoft.VisualStudio.Composition and everything works by deleting this line, I'm OK with not stating it. Our projects today over-specify a lot of package versions which makes things get annoying sometimes.

</ItemGroup>
<ItemGroup>
<InternalsVisibleToTest Include="Roslyn.VisualStudio.Services.UnitTests" />
Expand Down
Expand Up @@ -14,6 +14,8 @@ Imports Microsoft.VisualStudio.Text
Imports Microsoft.VisualStudio.Text.Editor
Imports Microsoft.VisualStudio.Utilities
Imports Moq

#Disable Warning BC40000 ' IQuickInfo* is obsolete
Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense

Public Class QuickInfoControllerTests
Expand Down Expand Up @@ -241,3 +243,4 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense
End Class
End Class
End Namespace
#Enable Warning BC40000 ' IQuickInfo* is obsolete
5 changes: 3 additions & 2 deletions src/EditorFeatures/TestUtilities/MinimalTestExportProvider.cs
Expand Up @@ -40,7 +40,8 @@ public static Type[] GetLanguageNeutralTypes()
typeof(DefaultSymbolMappingService),
typeof(TestWaitIndicator),
typeof(TestExtensionErrorHandler),
typeof(TestExportJoinableTaskContext) // Needed by editor components, but not actually exported anywhere else
typeof(TestExportJoinableTaskContext), // Needed by editor components, but not actually exported anywhere else
typeof(TestObscuringTipManager) // Needed by editor components, but only exported in editor VS layer. Tracked by https://devdiv.visualstudio.com/DevDiv/_workitems?id=544569.
};

return types//.Concat(TestHelpers.GetAllTypesWithStaticFieldsImplementingType(typeof(InternalSolutionCrawlerOptions).Assembly, typeof(Microsoft.CodeAnalysis.Options.IOption)))
Expand Down Expand Up @@ -124,7 +125,7 @@ public static PartDiscovery CreatePartDiscovery(Resolver resolver)

public static ExportProvider CreateExportProvider(ComposableCatalog catalog)
{
var configuration = CompositionConfiguration.Create(catalog.WithDesktopSupport().WithCompositionService());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var configuration = CompositionConfiguration.Create(catalog.WithCompositionService());
var runtimeComposition = RuntimeComposition.CreateRuntimeComposition(configuration);
return runtimeComposition.CreateExportProviderFactory().CreateExportProvider();
}
Expand Down
Expand Up @@ -79,6 +79,7 @@ private void InitializeWorkspace(TestWorkspace workspace)
_aggregator = new NavigateToTestAggregator(_provider);
}

#pragma warning disable CS0618 // MatchKind is obsolete
protected void VerifyNavigateToResultItems(
List<NavigateToItem> expecteditems, IEnumerable<NavigateToItem> items)
{
Expand Down Expand Up @@ -163,5 +164,6 @@ protected static int CompareNavigateToItems(NavigateToItem a, NavigateToItem b)
result = a.SecondarySort.CompareTo(b.SecondarySort);
return result;
}
#pragma warning restore CS0618 // MatchKind is obsolete
}
}
19 changes: 7 additions & 12 deletions src/EditorFeatures/TestUtilities/TestExportJoinableTaskContext.cs
@@ -1,24 +1,19 @@
using System;
using System.Collections.Generic;
using System.ComponentModel.Composition;
using System.Linq;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.Editor.Shared.Utilities;
using Microsoft.VisualStudio.Threading;

namespace Microsoft.CodeAnalysis.Editor.UnitTests
{
// In 15.3 the editor took a dependency on JoinableTaskContext.
// JTC appears in the VS MEF composition but does not itself
// contain an ExportAttribute. The Editor's own unit tests
// export it from a field and we need to do the same in order
// to be able to compose in any part of the Editor.
// Starting with 15.3 the editor took a dependency on JoinableTaskContext
// in Text.Logic and Intellisense layers as an editor host provided service.
[PartCreationPolicy(CreationPolicy.NonShared)] // JTC is "main thread" affinitized so should not be shared
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this file seem somewhat fishy to me:

  1. You're no longer using the CurrentForegroundThreadData which means this type doesn't need to inherit from ForegroundThreadAffinitizedObject anymore.
  2. Because of the previous point, there's no real reason to create an instance of this type at all...which seems that the creation policy doesn't matter.
  3. I don't see why this would be ThreadStatic, as we really shouldn't have tests that care about this then other than the ones that use our WpfFact to run on a single thread.
  4. The part creation policy should only matter in a single composition, which wouldn't have an impact on if it's being used across threads.

Maybe we have to just chat in person on this one, but what's going on here? This seems very magic and there's a lot of context missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me look at it again...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does look fishy, I wish I knew a better way.
Essentially what I found:

  1. Without non-shared part creation policy most most tests (specifically I believe non WpfFact ones) creating text view fail because new QuickInfo text view creation listener throws for not being on the main thread. I think that's because JTC instances are cached by MinimalTestExportProvider between compositions and so being reused on other threads.
  2. Without [ThreadStatic] tests deadlock, presumably because we end up creating more than one JTC for same thread.

This needs further investigation, I just don't have enough context in the text infrastructure. Maybe it would be better not to export JTC here, but explicitly add new instance to each composition?
I suggest creating an issue to track it, but not block this PR. I don't mind spending more time on this.

internal class TestExportJoinableTaskContext : ForegroundThreadAffinitizedObject
{
[ThreadStatic]
private static JoinableTaskContext s_joinableTaskContext;

[Export]
private JoinableTaskContext _joinableTaskContext = new JoinableTaskContext(
mainThread: ForegroundThreadAffinitizedObject.CurrentForegroundThreadData.Thread);
private JoinableTaskContext _joinableTaskContext = s_joinableTaskContext ?? (s_joinableTaskContext = new JoinableTaskContext());
}
}
21 changes: 21 additions & 0 deletions src/EditorFeatures/TestUtilities/TestObscuringTipManager.cs
@@ -0,0 +1,21 @@
using System.ComponentModel.Composition;
using Microsoft.VisualStudio.Text.Editor;

namespace Microsoft.CodeAnalysis.Editor.UnitTests
{
// In 15.6 the editor (QuickInfo in particular) took a dependency on
// IObscuringTipManager, which is only exported in VS editor layer.
// This is tracked by the editor bug https://devdiv.visualstudio.com/DevDiv/_workitems?id=544569.
// Meantime a workaround is to export dummy IObscuringTipManager.
[Export(typeof(IObscuringTipManager))]
internal class TestObscuringTipManager : IObscuringTipManager
{
public void PushTip(ITextView view, IObscuringTip tip)
{
}

public void RemoveTip(ITextView view, IObscuringTip tip)
{
}
}
}
Expand Up @@ -6,6 +6,7 @@ Imports Microsoft.VisualStudio.Composition
Imports Microsoft.VisualStudio.Language.Intellisense
Imports Microsoft.VisualStudio.Language.NavigateTo.Interfaces

#Disable Warning BC40000 ' MatchKind is obsolete
Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.NavigateTo
Public Class NavigateToTests
Inherits AbstractNavigateToTests
Expand Down Expand Up @@ -758,3 +759,4 @@ End Class
End Function
End Class
End Namespace
#Enable Warning BC40000 ' MatchKind is obsolete
Expand Up @@ -33,6 +33,7 @@ public void HACK_OnQuickInfoSessionDismissed(ITextView textView)
HACK_SetShimQuickInfoSessionWorker(textView, null);
}

#pragma warning disable CS0618 // IQuickInfo* is obsolete
private void HACK_SetShimQuickInfoSessionWorker(ITextView textView, IQuickInfoSession quickInfoSession)
{
var properties = textView.Properties.PropertyList;
Expand All @@ -53,7 +54,7 @@ private class HACK_QuickInfoSession : IQuickInfoSession
public event EventHandler ApplicableToSpanChanged;
public event EventHandler PresenterChanged;
#pragma warning restore 67

#pragma warning restore CS0618 // IQuickInfo* is obsolete
public PropertyCollection Properties
{
get
Expand Down
Expand Up @@ -50,7 +50,9 @@ internal partial class EventHookupCommandHandler : ForegroundThreadAffinitizedOb
public EventHookupCommandHandler(
IInlineRenameService inlineRenameService,
Microsoft.CodeAnalysis.Editor.Host.IWaitIndicator waitIndicator,
#pragma warning disable CS0618 // IQuickInfo* is obsolete
IQuickInfoBroker quickInfoBroker,
#pragma warning restore CS0618 // IQuickInfo* is obsolete
[Import(AllowDefault = true)] IHACK_EventHookupDismissalOnBufferChangePreventerService prematureDismissalPreventer,
[ImportMany] IEnumerable<Lazy<IAsynchronousOperationListener, FeatureMetadata>> asyncListeners)
{
Expand Down
Expand Up @@ -12,6 +12,7 @@
using Microsoft.VisualStudio.Text;
using Microsoft.VisualStudio.Text.Classification;

#pragma warning disable CS0618 // IQuickInfo* is obsolete
namespace Microsoft.CodeAnalysis.Editor.CSharp.EventHookup
{
internal sealed class EventHookupQuickInfoSource : IQuickInfoSource
Expand Down Expand Up @@ -101,3 +102,4 @@ public void Dispose()
}
}
}
#pragma warning restore CS0618 // IQuickInfo* is obsolete
Expand Up @@ -7,6 +7,7 @@
using Microsoft.VisualStudio.Text.Classification;
using Microsoft.VisualStudio.Utilities;

#pragma warning disable CS0618 // IQuickInfo* is obsolete
namespace Microsoft.CodeAnalysis.Editor.CSharp.EventHookup
{
/// <summary>
Expand Down Expand Up @@ -38,3 +39,4 @@ public IQuickInfoSource TryCreateQuickInfoSource(ITextBuffer textBuffer)
}
}
}
#pragma warning restore CS0618 // IQuickInfo* is obsolete