-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Using #27729
Merged
fayrose
merged 24 commits into
dotnet:features/enhanced-using
from
fayrose:pattern-using
Jun 28, 2018
Merged
Pattern Using #27729
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7f96f70
Initial commit, own tests passing
2c95c13
Fix pre-existing tests
377cd2c
Abstracted MessageID and fixed tests
e915f2f
Pre-existing tests updated
adf6e69
Expanded testing to cover ambiguous, inherited and extension cases.
5a98feb
Update error message to reflect that Dispose must be a non-static ins…
9554f56
Removed extraneous spacing
bcf2cb7
Minor fixes
92401fa
Moved return type checks to own classes
936e16c
Rename f(x)
609f674
Finished rename of methodOpt to DisposeMethodOpt
dfff3fe
Tiny fix
208e986
Fixed 1 failing test
2ce5a67
Method refactor
02aa307
Minor refactoring
ce10d18
Larger refactor
3be8998
Added expression using pattern tests in addition to declaration ones
c99f4fc
requested changes
2700f3d
Requested changes
4912594
Prioritizes iDisposable and fixes test cases
83bdbab
Fixed casting and else clause
20e472e
Reverted old tests
0f0ec15
Reverted emit tests
433ed8c
Requested changes
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it really have to be public? Or only accessible here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the foreach pattern requires public. Let's stick with that for now and I'll add it as a question for LDM in an email.