Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set working folder for the solution added. #31448

Merged
merged 2 commits into from Dec 4, 2018

Conversation

heejaechang
Copy link
Contributor

@heejaechang heejaechang commented Nov 29, 2018

persistent service requires working folder location to find out where to save its persistent file

...

user impact is

  1. FAR, Navigate To can be slow than needed at warm solution loaded
  2. VS uses more memory than needed.

persistent service requires working folder location to find out where to save its persistent file
@heejaechang heejaechang requested a review from a team as a code owner November 29, 2018 21:44
@heejaechang
Copy link
Contributor Author

@jasonmalinowski @dotnet/roslyn-ide can you take a look?

tagging @jinujoseph for preview 2

@heejaechang
Copy link
Contributor Author

heejaechang commented Nov 30, 2018

added integration test for working folder

@heejaechang
Copy link
Contributor Author

@jasonmalinowski can you take a look?

Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubly approving for the addition of an integration test!

@jinujoseph
Copy link
Contributor

On hold till we make the current preview2 insertion

@heejaechang heejaechang merged commit 62303cb into dotnet:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants