Commits on Dec 18, 2018

1. Decouple a bit of RenameTrackingTaggerProvider …

   This addresses a timing issue, where we would call
   UpdateTrackingSessionIfRenamable even the session had already been
   dismissed; this function implicitly assumed the session making the
   call was still active. Another helper function OnTrackingSessionUpdated
   which raises the session update events already had checks for this,
   but UpdateTrackingSessionIfRenamable bypassed that. The core of this
   fix is to remove the offending code in UpdateTrackingSessionIfRenameable
   and just have the TrackingSession call OnTrackingSessionUpdated. That's
   already done in many other places and is much simpler.
   
   Upon further inspection of UpdateTrackingSessionIfRenamable it was
   also suspicious because it was having to grovel in the state of the
   active session to know if it should call CheckNewIdentifier. Moving that
   check into the function directly simplifies the code and decouples
   the types just a little bit.

   

   jasonmalinowski committed Dec 18, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for a603471
   • Browse repository at this point

   Copy the full SHA

   a603471 View commit details

   Browse the repository at this point in the history