Merge dev16.0-preview2 to features/enhanced-using #32384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. we never disposed tag aggregator leaking all taggers ever created on the buffer involved in contained document 2. we hold on to taggers not related to our buffer but ones that are related to other buffers. for example, our subject buffer is actually subject buffer which involves template C# buffer + html buffer where portion of html buffer are mapped to the subject buffer. that we end up holding on to all html taggers.
ghost
merged commit 
dotnet-bot
restored the
merges/dev16.0-preview2-to-features/enhanced-using
branch
dotnet-bot
deleted the
merges/dev16.0-preview2-to-features/enhanced-using
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev16.0-preview2 into features/enhanced-using.
git fetch --all git checkout merges/dev16.0-preview2-to-features/enhanced-using git reset --hard upstream/features/enhanced-using git merge upstream/dev16.0-preview2 # Fix merge conflicts git commit git push merges/dev16.0-preview2-to-features/enhanced-using --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.