Compare constraints lazily across partial type declarations #34850
Conversation
| { | ||
| var typeParameters = TypeParameters; | ||
|
|
||
| if (constraintClauses.Length > 0) |
There was a problem hiding this comment.
if (constraintClauses.Length > 0) [](start = 12, length = 33)
Is this check redundant? #Closed
| private ImmutableArray<TypeParameterConstraintClause> MakeTypeParameterConstraintsLate( | ||
| ImmutableArray<TypeParameterConstraintClause> constraintClauses, | ||
| DiagnosticBag diagnostics) | ||
| { |
There was a problem hiding this comment.
{ [](start = 8, length = 1)
Consider adding an assert constraintClauses.IsEarly() #Closed
|
Could you provide some details on what was the root cause of the stack overflow? #Closed |
|
Done with review pass (iteration 1) #Closed |
|
In reply to: 481044805 [](ancestors = 481044805) |
|
@dotnet/roslyn-compiler please review. |
cston
added
the
New Language Feature - Nullable Reference Types
| }"; | ||
| var comp = CreateCompilation(new[] { source1, source2 }); | ||
| comp.VerifyDiagnostics( | ||
| // (3,15): error CS0265: Partial declarations of 'C<T>' have inconsistent constraints for type parameter 'T' |
There was a problem hiding this comment.
Probably unrelated, but this is a terrible error message. We should say what the inconsistencies are. #Resolved
Fixes #34841.