Pool analyzer diagnostic reporters #39034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
force-pushed
the
pool-diagnostic-reporters
branch
2 times, most recently
from
1974cad
to
fc4bf87
Compare
agocke
force-pushed
the
pool-diagnostic-reporters
branch
2 times, most recently
from
80bb300
to
bf2563a
Compare
This has shown up as a significant source of allocations. The design here is that when an analyzer reports a diagnostic we may need to filter or alter it based on some configuration. Previously we stored the configuration information by closing over captured variables, but that could be very expensive if it's being done for every analyzer invocation. Since we can only really execute one analyzer per running thread on the machine, the actual number of concurrent objects we need to create is approximately the number of running threads. Pooling is a good solution to this problem.
agocke
force-pushed
the
pool-diagnostic-reporters
branch
from
bf2563a
to
f34b4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has shown up as a significant source of allocations. The design
here is that when an analyzer reports a diagnostic we may need to filter
or alter it based on some configuration. Previously we stored the
configuration information by closing over captured variables, but that
could be very expensive if it's being done for every analyzer
invocation. Since we can only really execute one analyzer per running
thread on the machine, the actual number of concurrent objects we need
to create is approximately the number of running threads. Pooling is a
good solution to this problem.
Before:
After:
Note: I don't think this is that much faster -- my machine wasn't completely quiet during the noise measurements, but I do believe that bytes allocated is accurate and a significant improvement.