Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix so move to namespace also works for enums when selected #39798

Merged
merged 1 commit into from Nov 14, 2019
Merged

Fix so move to namespace also works for enums when selected #39798

merged 1 commit into from Nov 14, 2019

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Nov 12, 2019 •
edited

Also use Fact instead of WpfFact since these tests don't need Wpf.

Fixes #36717

@ryzngard ryzngard requested a review from a team as a code owner November 12, 2019 23:32
@ryzngard ryzngard requested a review from genlu November 12, 2019 23:32
JoeRobich
JoeRobich approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryzngard ryzngard merged commit 2e17fc6 into dotnet:master Nov 14, 2019
@ryzngard ryzngard deleted the issue/36717_move_namespace_enum branch November 14, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@mavasani mavasani mavasani approved these changes

@genlu genlu Awaiting requested review from genlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C# Refactoring: move to namespace not available for enums
3 participants
@ryzngard @JoeRobich @mavasani