Make AnalyzerActions a value type #40691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Jan 2, 2020
333fred
reviewed
Jan 2, 2020
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerDriver.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jan 2, 2020
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerManager.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jan 2, 2020
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerManager.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jan 2, 2020
src/Compilers/Core/Portable/DiagnosticAnalyzer/DiagnosticStartAnalysisScope.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jan 2, 2020
src/Compilers/Core/Portable/DiagnosticAnalyzer/DiagnosticStartAnalysisScope.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jan 2, 2020
src/Compilers/Core/Portable/DiagnosticAnalyzer/DiagnosticStartAnalysisScope.cs
Show resolved
Hide resolved
|
Done review pass (commit 7) |
sharwell
changed the title
sharwell
changed the title
|
The initially observed regression turned out to be a bug in .NET Core: dotnet/runtime#1713. |
|
Done review pass (commit 9) |
sharwell
force-pushed
the
analyzer-actions-struct
branch
from
09d6be3
to
08981b8
Compare
agocke
reviewed
Jan 17, 2020
| private ImmutableArray<OperationAnalyzerAction> _operationActions = ImmutableArray<OperationAnalyzerAction>.Empty; | ||
| public static readonly AnalyzerActions Empty = new AnalyzerActions(concurrent: false); | ||
|
|
||
| private ImmutableArray<CompilationStartAnalyzerAction> _compilationStartActions; |
There was a problem hiding this comment.
Can we just make these get-only autoprops?
There was a problem hiding this comment.
The Add* methods mutate these fields in the current revision. A future change could make this struct immutable.
| @@ -628,126 +628,187 @@ protected AnalyzerActions GetOrCreateAnalyzerActions(DiagnosticAnalyzer analyzer | |||
| // moves from an analyzer-centric model to an action-centric model. For example, the driver would need to stop asking | |||
| // if a particular analyzer can analyze syntax trees, and instead ask if any syntax tree actions are present. Also, | |||
| // the driver needs to apply all relevant actions rather then applying the actions of individual analyzers. | |||
| internal sealed class AnalyzerActions | |||
| internal struct AnalyzerActions | |||
There was a problem hiding this comment.
Can this be a readonly struct with IsEmpty and Concurrent moved to a With-ing pattern?
There was a problem hiding this comment.
No, this is still a mutable struct. It would be a decent size change to convert all the remaining mutation methods to immutable transforms.
agocke
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39102
Reduces allocations during analysis of Roslyn.sln by many GB (6 GB, ~2.4%).
Baseline (c0c68fc):
Updated (c0c68fc + 4c37d9a)