Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind expression variables appearing in a goto case statement. #41709

Merged
merged 5 commits into from Feb 22, 2020

Conversation

gafter
Copy link
Member

@gafter gafter commented Feb 14, 2020

Fixes #40714

@gafter gafter added this to the 16.6 milestone Feb 14, 2020
@gafter gafter requested a review from a team as a code owner February 14, 2020 21:11
@gafter gafter self-assigned this Feb 14, 2020
@gafter
Copy link
Member Author

gafter commented Feb 14, 2020

@dotnet/roslyn-compiler May I please have a couple of reviews of this small bug fix? #Resolved

@gafter gafter added this to In Review in Compiler: Pattern-Matching Feb 14, 2020
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Feb 14, 2020

Done with review pass (iteration 1) #Closed

@gafter
Copy link
Member Author

gafter commented Feb 21, 2020

@AlekseyTs I think I've responded to your comments. Do you have any others?

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 4)

@gafter gafter merged commit b3cbe7a into dotnet:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

C#: Typing goto case (ValueTuple<,>) in switch statement crashes Visual Studio
3 participants