Remove unneeded suppression #48277
Remove unneeded suppression #48277
Conversation
| #pragma warning disable IDE0044 // Add readonly modifier - See https://github.com/dotnet/roslyn/issues/47225 | ||
| private volatile int m_owner; | ||
| #pragma warning restore IDE0044 // Add readonly modifier | ||
| private readonly int m_owner; |
There was a problem hiding this comment.
It needs a careful review.
I removed volatile assuming that this can't be modified by multiple threads. If that is not correct, we may need to update the analyzer.
There was a problem hiding this comment.
It needs a careful review.
I removed volatile assuming that this can't be modified by multiple threads. If that is not correct, we may need to update the analyzer.
@mavasani, As I'm not 100% sure of the change. So pinging you on this in case this comment was unnoticed.
jinujoseph
added
Area-IDE
Community
|
Hello @mavasani! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@Youssef1313 The CI has failures. |
ghost
removed
the
|
@mavasani That's weird. The CI failure sounds correct, but it is unrelated to the change made here. I'm not sure why it's not failing on the current master. |
| @@ -37,7 +35,7 @@ public bool IsThreadOwnerTrackingEnabled | |||
|
|
|||
| internal class SpinLockDebugView | |||
| { | |||
| private MockDesktopSpinLock m_spinLock; | |||
| private readonly MockDesktopSpinLock m_spinLock; | |||
There was a problem hiding this comment.
This should have been failing in the current master. This line is after restoring IDE0044.
There was a problem hiding this comment.
Yes, this seems weird indeed. Maybe needs a follow-up investigation..
Closes #47225