Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support warning numbers in Quick Info for suppressions #49102

Merged
merged 15 commits into from
Nov 23, 2020

Conversation

MaStr11
Copy link
Contributor

@MaStr11 MaStr11 commented Oct 31, 2020

Fixes #49008
Follow-up to #46817

@MaStr11 MaStr11 requested a review from a team as a code owner October 31, 2020 14:13
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Nov 1, 2020
@jinujoseph jinujoseph added this to InQueue in IDE: CommunityPR via automation Nov 1, 2020
@jinujoseph jinujoseph moved this from InQueue to BuddyAssigned in IDE: CommunityPR Nov 1, 2020
@MaStr11
Copy link
Contributor Author

MaStr11 commented Nov 21, 2020

Hi @mavasani, can you please have a look.

IDE: CommunityPR automation moved this from BuddyAssigned to LGTM Nov 23, 2020
@mavasani
Copy link
Contributor

Thanks @MaStr11!

@mavasani mavasani merged commit f59f0b5 into dotnet:master Nov 23, 2020
IDE: CommunityPR automation moved this from LGTM to Completed Nov 23, 2020
@ghost ghost added this to the Next milestone Nov 23, 2020
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
@MaStr11 MaStr11 deleted the FixPragmaWarningCompilerNumbers branch December 1, 2020 16:42
@jinujoseph jinujoseph moved this from Completed-180 to Completed 2020 in IDE: CommunityPR Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
IDE: CommunityPR
  
Completed 2020
Development

Successfully merging this pull request may close these issues.

Quick Info for suppressions does not work for compiler warning numbers
5 participants