Do not use declared constant's value inside a nameof() expression #503
Conversation
|
I also changed all of the tabs in SourceLocalSymbol to spaces. |
|
@VladimirReshetnikov @VSadov Can you please review this? |
gafter
added
Area-Compilers
4 - In Review
|
@Jenkins test this please |
|
To: @AlekseyTs @agocke @VSadov @VladimirReshetnikov @jaredpar Can a couple of you please take a look? |
| @@ -5244,7 +5245,7 @@ private static void CombineExtensionMethodArguments(BoundExpression receiver, An | |||
|
|
|||
| ConstantValue constantValueOpt = null; | |||
|
|
|||
| if (fieldSymbol.IsConst) | |||
| if (fieldSymbol.IsConst && this.EnclosingNameofArgument == null) | |||
There was a problem hiding this comment.
Meaning "there is no enclosing nameof expression"
There was a problem hiding this comment.
Consider adding this as a comment
|
Does this need a test in the semantic model? |
|
@agocke What would you like to see tested? Or do you mean the semantic model may need to be adjusted to accomodate the change? |
|
@gafter Just that the semantic model also successfully binds without diagnostics. |
| @@ -1138,5 +1138,22 @@ public static void Main(string[] args) | |||
| Assert.Equal(CandidateReason.MemberGroup, symbolInfo.CandidateReason); | |||
| Assert.Equal(1, symbolInfo.CandidateSymbols.Length); | |||
| } | |||
|
|
|||
| [Fact, WorkItem(40, "github.com/dotnet/roslyn")] | |||
| public void ConstInitializerUsingSelf() | |||
There was a problem hiding this comment.
Please add similar test for VB.
|
LGTM. We should have the same test for VB. |
Do not use declared constant's value inside a nameof() expression
Fixes #40