Move search under tabs #57188
Merged
Move search under tabs #57188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jmarolf
force-pushed
the
feature/move-search-bar-under-tabs
branch
from
ea811d3
to
ecff21a
Compare
|
Love this. Looks likely this will need a UX Review pass for a11y. Looking at the code now for review, but wanted to give you a heads up. |
ryzngard
approved these changes
Oct 27, 2021
src/VisualStudio/Core/Def/EditorConfigSettings/Analyzers/ViewModel/SeverityViewModel.cs
Outdated
Show resolved
Hide resolved
...alStudio/Core/Def/EditorConfigSettings/Extensions/IVsUIDataSourceSearchSettingsExtensions.cs
Outdated
Show resolved
Hide resolved
...alStudio/Core/Def/EditorConfigSettings/Extensions/IVsUIDataSourceSearchSettingsExtensions.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/EditorConfigSettings/SettingsEditorControl.xaml.cs
Outdated
Show resolved
Hide resolved
Feedback from the UX team I am going to try and address |
…IDataSourceSearchSettingsExtensions.cs Co-authored-by: Andrew Hall <ryzngard@live.com>
previsouly the scollbar wasn't getting styles because the tabular-data-control was being hoested in a frame
"Could use a little extra spacing underneath to visually separate it from the column headers just a bit (for aesthetic reasons; looks a bit cramped)"
Turns out I can just cast IVsUIDataSource to a SearchSettingsDataSource, simplified things
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8 tasks
ryzngard
added
UX Review Not Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Whitespace
Code Style
Analyzers
After:
Whitespace
Code Style
Analyzers