Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move search under tabs #57188

Merged
merged 9 commits into from
Nov 1, 2021
Merged

Move search under tabs #57188

merged 9 commits into from
Nov 1, 2021

Conversation

jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Oct 17, 2021 •
edited
Loading

Before:

Whitespace

image

Code Style

image

Analyzers

image

After:

Whitespace

image

Code Style

image

Analyzers

image

@ghost ghost added the Needs UX Triage label Oct 17, 2021
@jmarolf jmarolf force-pushed the feature/move-search-bar-under-tabs branch from ea811d3 to ecff21a Compare October 27, 2021 09:07
@jmarolf jmarolf marked this pull request as ready for review October 27, 2021 09:13
@jmarolf jmarolf requested a review from a team as a code owner October 27, 2021 09:13
@jmarolf jmarolf requested a review from ryzngard October 27, 2021 19:14
@ryzngard
Copy link
Contributor

Love this. Looks likely this will need a UX Review pass for a11y. Looking at the code now for review, but wanted to give you a heads up.

@jmarolf
Copy link
Contributor Author

jmarolf commented Oct 28, 2021

  • Could use a little extra spacing underneath to visually separate it from the column headers just a bit (for aesthetic reasons; looks a bit cramped)
  • It might not hurt to make the box a bit wider if you think users are likely to enter longer or multiple search terms

Feedback from the UX team I am going to try and address

jmarolf and others added 6 commits October 28, 2021 10:52
@jmarolf @ryzngard
Update src/VisualStudio/Core/Def/EditorConfigSettings/Extensions/IVsU…
4ab127e 
…IDataSourceSearchSettingsExtensions.cs

Co-authored-by: Andrew Hall <ryzngard@live.com>
@jmarolf
move field near property
e38b6ce
@jmarolf
fix switch doc commetns on Border and Padding extension methods
01067e1
@jmarolf
throw an invalid operation exception if we cannot get the tab
19c74a3
@jmarolf
Use ContentPresenter to ensure style propogate correctly
060dbc2 
previsouly the scollbar wasn't getting styles because the tabular-data-control was being hoested in a frame
@jmarolf
fixing UX feedback
e1b7e21 
"Could use a little extra spacing underneath to visually separate it from the column headers just a bit (for aesthetic reasons; looks a bit cramped)"
@runfoapp runfoapp bot mentioned this pull request Oct 28, 2021
Open
@jmarolf
Improvie search control size
22ece14 
Turns out I can just cast IVsUIDataSource to a SearchSettingsDataSource, simplified things
@jmarolf
Copy link
Contributor Author

jmarolf commented Nov 1, 2021

/azp run roslyn-integration-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jmarolf jmarolf merged commit 9f3a05d into dotnet:main Nov 1, 2021
@ghost ghost added this to the Next milestone Nov 1, 2021
@jmarolf jmarolf mentioned this pull request Nov 1, 2021
Open
8 tasks
@runfoapp runfoapp bot mentioned this pull request Nov 3, 2021
Closed
@vatsalyaagrawal vatsalyaagrawal modified the milestones: Next, 17.1.P2 Nov 5, 2021
@jmarolf jmarolf mentioned this pull request Nov 5, 2021
Closed
@jmarolf jmarolf mentioned this pull request Dec 6, 2021
Open
@ryzngard ryzngard added UX Review Not Required UX Review Not Required and removed Needs UX Triage labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzngard ryzngard ryzngard approved these changes

Assignees
No one assigned
Labels
Area-IDE UX Review Not Required UX Review Not Required
Projects
None yet
Milestone
17.1.P2
Development

Successfully merging this pull request may close these issues.
3 participants
@jmarolf @ryzngard @vatsalyaagrawal