[SourceLink] Go To Def tab improvements #57995
Conversation
davidwengier
changed the title
| var documentName = string.Format( | ||
| "{0} [{1}]", | ||
| navigateDocument!.Name, | ||
| FeaturesResources.from_metadata); | ||
| sourceFileInfos[0]!.SourceDescription); |
There was a problem hiding this comment.
What does it mean for sourceFileInfos to be an array here? If the first is significant/special, can we extract that out to a local (that's also been null-suppressed once) rather than duplicating it everywhere?
There was a problem hiding this comment.
Unfortunately for now, the first is not special, but whilst GoToDef supports multiple locations, MetadataAsSoruce doesn't, so there is some refactoring of things that needs to happen I haven't started to look at yet. A local is probably a good idea
| @@ -2948,4 +2948,12 @@ Zero-width positive lookbehind assertions are typically used at the beginning of | |||
| <data name="Silent" xml:space="preserve"> | |||
| <value>Silent</value> | |||
| </data> | |||
| <data name="embedded" xml:space="preserve"> | |||
| <value>embedded</value> | |||
| <comment>Embedded is a technical term for "Embedded source", where souce files are embedded into the PDB</comment> | |||
There was a problem hiding this comment.
On behalf of the translation teams, thank you for adding comments like this. 😄
| <value>external</value> | ||
| <comment>External means "external source", meaning source files that are not part of the current solution</comment> |
There was a problem hiding this comment.
Do we really need to tag this specially, if it's opening a file on your machine? Like does this get strange if you then want to edit that file like a local file, or add that missing project to your solution?
There was a problem hiding this comment.
Or are we taking the on-disk file and copying it to a temp folder?
There was a problem hiding this comment.
No, you were right, this is a file on your machine.. but we open it readonly, and if you were to edit it, then we wouldn't find it because the checksum wouldn't match. If we didn't tag it specifically, what would we say? I don't think it should look like a normal file, because its not in the solution, so lots of things don't work like normal (and as mentioned, its readonly). I don't think the tab should say "from metadata", because its the real source. So "external" is the best I could come up with. "local" I guess could work?
|
Closing this. Going to combine with the output window logging, and add some telemetry, in a follow up since this missed Preview 2 anyway. |
Part of #55834
Includes #57978 so just review
2b6c31a(#57995)Tabs look like this now: