Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Stack Trace Explorer automatic open behavior scope #58819

Merged
merged 1 commit into from Jan 13, 2022

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Jan 13, 2022

Fix so that the stack trace explorer only automatically activates on focus if the clipboard has "at" trivia in the frame.

Fixes #58746

…focus if the clipboard has "at" trivia in the frame.
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you <3

@ryzngard ryzngard enabled auto-merge (squash) January 13, 2022 01:32
@ryzngard ryzngard merged commit 775af69 into dotnet:main Jan 13, 2022
@ghost ghost added this to the Next milestone Jan 13, 2022
@ryzngard ryzngard deleted the issues/stacktrace_activate_fix branch January 18, 2022 22:23
ryzngard added a commit to ryzngard/roslyn that referenced this pull request Jan 20, 2022
Fix so that the stack trace explorer only automatically activates on focus if the clipboard has "at" trivia in the frame.

Fixes dotnet#58746
@ryzngard ryzngard mentioned this pull request Jan 20, 2022
RikkiGibson added a commit that referenced this pull request Jan 20, 2022
…58970)

Fix so that the stack trace explorer only automatically activates on focus if the clipboard has "at" trivia in the frame.

Fixes #58746
333fred added a commit that referenced this pull request Jan 24, 2022
…merges/release/dev17.1-vs-deps-to-main

* upstream/release/dev17.1-vs-deps:
  Cleanup missed suggestion
  Update src/Workspaces/Core/Portable/Classification/ClassifierHelper.cs
  SpillSequenceSpiller.Spill - ensure sequences under ref assignments are spilled. (#58657) (#58788)
  Correctly update the list of generators for a call to WithAnalyzerReferences
  Rename parameter for what it's actually doing
  Handle AdditiveSpans in either order
  Reduce Stack Trace Explorer automatic open behavior scope (#58819)
  Revert 58892 (#58930)
  Mark APIs as shipped (#58776)
  Revert "Merge pull request #57132 from CyrusNajmabadi/branchId3"
  Fix race in WorkCoordinator when handling document reanalysis
  Remove unnecessary lock access setting UIContexts in the workspace
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack Trace Explorer pops up unexpectedly
4 participants