Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit CompilerFeaturesRequiredAttribute #61388

Merged
merged 2 commits into from May 19, 2022

Conversation

333fred
Copy link
Member

@333fred 333fred commented May 18, 2022

Support emitting CompilerFeatureRequiredAttribute for ref structs (when the attribute is present) and for required members (error if the attribute is not present).

Test plan: #57046.

@333fred 333fred requested review from RikkiGibson and jcouv May 18, 2022 21:05
@333fred 333fred requested a review from a team as a code owner May 18, 2022 21:05
@333fred
Copy link
Member Author

333fred commented May 18, 2022

@jcouv @RikkiGibson please take a look.

@333fred 333fred added the New Feature - Required Members Required properties and fields label May 18, 2022
@RikkiGibson RikkiGibson self-assigned this May 18, 2022
@333fred
Copy link
Member Author

333fred commented May 18, 2022

@jcouv for the second review.

@333fred
Copy link
Member Author

333fred commented May 18, 2022

/azp run roslyn-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@333fred 333fred enabled auto-merge (rebase) May 19, 2022 22:07
@333fred 333fred merged commit cb14f67 into dotnet:features/required-members May 19, 2022
@333fred 333fred deleted the apply-poison branch May 20, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants