Address prototype comments in file types branch #62335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cston
reviewed
Jul 1, 2022
cston
reviewed
Jul 1, 2022
This comment was marked as resolved.
This comment was marked as resolved.
cston
reviewed
Jul 1, 2022
src/Compilers/CSharp/Test/Syntax/Parsing/FileModifierParsingTests.cs
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
cston
approved these changes
Jul 2, 2022
This comment was marked as resolved.
This comment was marked as resolved.
jcouv
reviewed
Jul 5, 2022
| @@ -427,3 +427,16 @@ class @required {} // No error | |||
| This was done as `required` is now a member modifier for properties and fields. | |||
|
|
|||
| You can learn more about this change in the associated [csharplang issue](https://github.com/dotnet/csharplang/issues/3630). | |||
|
|
|||
| ## Types cannot be named `file` | |||
There was a problem hiding this comment.
Please place the new entry at the top. We changed the order when mirroring process to docs.microsoft.com started (was done in #60260)
jcouv
reviewed
Jul 5, 2022
| """, | ||
| expectedBindingDiagnostics: new[] | ||
| { | ||
| // (1,7): error CS9056: Types and aliases cannot be named 'file'. |
There was a problem hiding this comment.
Let's also test this scenario (type named "file") with C# 10
jcouv
approved these changes
Jul 5, 2022
|
Verified that the most recent changes pass locally and will verify in CI when merging to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #60819