Use "file local types" instead of "file types" #62514
Conversation
| { | ||
| if (!possibleFileType.IsFile) | ||
| if (!possibleFileLocalType.IsFile) |
There was a problem hiding this comment.
.IsFile
Is there a missing rename here?
I see the implementation is about the modifier, but I think the API itself is meant to be about the language concept?
There was a problem hiding this comment.
Renamed to IsFileLocal.
| @@ -122,6 +122,6 @@ public override string MetadataName | |||
|
|
|||
| public bool IsSerializable => false; | |||
|
|
|||
| public bool IsFile => Modifiers.IsFile; | |||
| public bool IsFileLocal => Modifiers.IsFile; | |||
There was a problem hiding this comment.
I don't feel strongly about this here. It's an internal API so don't think there's a rush to make it happen.
There was a problem hiding this comment.
@RikkiGibson But that applies to the public INamedTypeSymbol.IsFileLocal property as well?
There was a problem hiding this comment.
good point (: I missed that this was an implementation of INamedTypeSymbol.IsFileLocal.
IMO, I think IsFileLocal is better because we anticipate generalizing the file-local concept to non-type members. If this happens, we might end up introducing API like ISymbol.IsFileLocal and then the INamedTypeSymbol.IsFileLocal would shadow it.
There was a problem hiding this comment.
Oops, I could have placed the comment in a better location ;-)
we might end up introducing API like ISymbol.IsFileLocal and then the INamedTypeSymbol.IsFileLocal would shadow it.
Makes sense. Thanks
ghost
added this to the 
related to #62254 and #60819
We use "file local types" to refer to the language concept, e.g. in
INamedTypeSymbol.IsFileLocal. When we are only asking whether a declaration literally has thefilemodifier we still sayIsFile, e.g. inSyntaxGenerator.