Address feedback on the "references newer compiler" diagnostic in the analyzer loader #62627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
commented
Jul 13, 2022
| { | ||
| ReferencedCompilerVersion = errorCode is AnalyzerLoadFailureEventArgs.FailureErrorCode.ReferencesNewerCompiler ? new Version(100, 0, 0, 0) : null | ||
| }; | ||
| typeNameOpt: expectsTypeName ? analyzerTypeName : null); |
There was a problem hiding this comment.
It feels like the goal of this test could be accomplished by introducing some internal helper to CreateAnalyzerLoadFailureDiagnostic which asserts that the FailureErrorCode falls within an expected range, then running the test on that helper instead of CreateAnalyzerLoadFailureDiagnostic itself. I'd prefer to keep the change minimal here for now, though.
|
@333fred did we expect fabric-bot to leave a comment here? |
jaredpar
approved these changes
Jul 13, 2022
|
@Cosifne once we get this merged, we should be good to push thru QB. |
cston
approved these changes
Jul 14, 2022
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #61261
Closes #62583