Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Required Members for VB #66084

Merged
merged 22 commits into from May 10, 2023
Merged

Implement Required Members for VB #66084

merged 22 commits into from May 10, 2023

Commits on Dec 21, 2022

  1. Configuration menu
    Copy the full SHA
    6615a4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c254bc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de998f8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9b6b8af View commit details
    Browse the repository at this point in the history
  5. Implement remaining errors:

    * Block inheriting from types with required members
    * Block calling constructors with invalid required member lists
    * Block substituting types with required members in As New, unless the parameterless ctor has SetsRequiredMembers.
    333fred committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    98167b1 View commit details
    Browse the repository at this point in the history
  6. Fill out all tests

    333fred committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    7890731 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. PR feedback

    333fred committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    7b744a5 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. PR feedback#

    333fred committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    9ae7f8d View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. PR Feedback

    333fred committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    30ea028 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b00b758 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7ec94f5 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Merge remote-tracking branch 'upstream/main' into vb-required

    * upstream/main: (547 commits)
      Add VerifyMethodBody helper as a replacement of VerifyIL (dotnet#66536)
      don't offer rename for ctor snippet (dotnet#66704)
      Get `ConditionalAttribute` type only once per compilation
      Convert language-specific option types to records (dotnet#66633)
      Enable MSBuild COMM log (dotnet#66708)
      ⚡️Share AssemblyloadTestFixture on Framework (dotnet#66684)
      NRT
      Don't overwrite binary logs in CI (dotnet#66683)
      Fix 'Generate Enum Member' to work in a 'Color Color' case.
      Find bitwise operators accessed through logical operators in FAR
      Semantic snippets - `propg` and `propi` snippets (dotnet#65979)
      NRT
      Properly classify aliases in quick info
      Fix
      Add tests
      Add support for finding collection initialiers with FAR
      Do not suggest replacing lambda with method group if the invoked mehod has `Conditional` attribute
      Revert "Record added node output states as new (dotnet#61575)" (dotnet#66696)
      Record added node output states as new (dotnet#61575)
      Fix formatting issue with convert-to-full-prop
      ...
    333fred committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    624934a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Addressed a number of PR feedback comments. Lots of new tests, fixed …

    …a few revealed bugs, handle Nothing converted to a struct with required members.
    333fred committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    73d1d26 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. PR feedback

    * Remove Nothing handling to align with C#.
    * Remove suppressions of cascading errors.
    * Expand unbound test coverage.
    * Expand tuple test coverage.
    333fred committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    8c9cff4 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Configuration menu
    Copy the full SHA
    58072b4 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Merge remote-tracking branch 'upstream/main' into vb-required

    * upstream/main: (2060 commits)
      implement code folding for anonymous objects
      Cleanup/perf in creating member maps. (dotnet#67997)
      Address feedback, clean the use of ILegacyGlobalOptionsWorkspaceService
      Update Publish.json
      Semantic snippets: Add inline statement snippets (dotnet#67819)
      Update VSSDK Build tools version
      Update doc comment
      Address feedback
      Move declaration near reference
      Address feedback
      Avoid stack overflow due to deep recursion on long chain of calls. (dotnet#67913)
      Check ILegacyGlobalOptionsWorkspaceService is null
      test scout queue
      add test
      update editor
      "Where" clause typo fix (dotnet#68002)
      Use `Keyword` helper method instead of hardcoding keyword help terms
      Move the SyntaxTree and SemanticModel action based analyzers to respect context.FilterSpan
      EnC refactoring: Align wrappers with contracts better (dotnet#67967)
      Include EA.RazorCompiler in source build (dotnet#67996)
      ...
    333fred committed May 2, 2023
    Configuration menu
    Copy the full SHA
    610d5f4 View commit details
    Browse the repository at this point in the history
  2. Fix test baseline

    333fred committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e1e3866 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Configuration menu
    Copy the full SHA
    7b2052e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebb5f25 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Remove unnecessary imports

    333fred committed May 10, 2023
    Configuration menu
    Copy the full SHA
    e9e4ba6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    748793f View commit details
    Browse the repository at this point in the history
  3. Fix C# equivalent code.

    333fred committed May 10, 2023
    Configuration menu
    Copy the full SHA
    5575087 View commit details
    Browse the repository at this point in the history