Generate branchless IL for `(b ? 1 : 0)` #67191

jjonescz · 2023-03-06T16:07:30Z

Resolves #61483.

Benchmarks (source)

BenchmarkDotNet=v0.13.5, OS=Windows 11 (10.0.22621.1265/22H2/2022Update/SunValley2), VM=Hyper-V
Intel Xeon Platinum 8370C CPU 2.80GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK=8.0.100-preview.1.23115.2
  [Host]     : .NET 8.0.0 (8.0.23.11008), X64 RyuJIT AVX2
  Job-GWYXTQ : .NET 7.0.3 (7.0.323.6910), X64 RyuJIT AVX2
  Job-ZKBEJK : .NET 7.0.3 (7.0.323.6910), X64 RyuJIT AVX2
  Job-FEGVAA : .NET 8.0.0 (8.0.23.11008), X64 RyuJIT AVX2
  Job-PVAAGM : .NET 8.0.0 (8.0.23.11008), X64 RyuJIT AVX2

Method	Runtime	BuildConfiguration	Mean	Ratio	Code Size
Compare1	.NET 7.0	Release	0.6837 ns	1.05	25 B
Compare1	.NET 7.0	ReleaseCustomRoslyn	0.6531 ns	1.05	25 B
Compare1	.NET 8.0	Release	0.6459 ns	1.00	25 B
Compare1	.NET 8.0	ReleaseCustomRoslyn	0.6447 ns	1.00	25 B

Compare2	.NET 7.0	Release	0.6012 ns	0.71	31 B
Compare2	.NET 7.0	ReleaseCustomRoslyn	0.2925 ns	0.35	20 B
Compare2	.NET 8.0	Release	0.8460 ns	1.00	31 B
Compare2	.NET 8.0	ReleaseCustomRoslyn	0.1157 ns	0.18	20 B

Compare3	.NET 7.0	Release	0.7485 ns	0.85	32 B
Compare3	.NET 7.0	ReleaseCustomRoslyn	0.5573 ns	0.64	37 B
Compare3	.NET 8.0	Release	0.8691 ns	1.00	32 B
Compare3	.NET 8.0	ReleaseCustomRoslyn	0.6283 ns	0.72	37 B

public int Compare1(int x, int y)
{
    if (x < y) return -1;
    if (x > y) return 1;
    return 0;
}

public int Compare2(int x, int y)
{
    int tmp1 = (x > y) ? 1 : 0;
    int tmp2 = (x < y) ? 1 : 0;
    return tmp1 - tmp2;
}

public int Compare3(char c)
{
    return (c >= 'A' && c <= 'Z' || c >= 'a' && c <= 'z') ? 1 : 0;
}

Compare2 Release

; Program.Compare2(Int32, Int32)
       cmp       edx,r8d
       jg        short M00_L00
       xor       eax,eax
       jmp       short M00_L01
M00_L00:
       mov       eax,1
M00_L01:
       cmp       edx,r8d
       jl        short M00_L02
       xor       edx,edx
       jmp       short M00_L03
M00_L02:
       mov       edx,1
M00_L03:
       sub       eax,edx
       ret
; Total bytes of code 31

Compare2 ReleaseCustomRoslyn

; Program.Compare2(Int32, Int32)
       xor       eax,eax
       cmp       edx,r8d
       setg      al
       cmp       edx,r8d
       setl      dl
       movzx     edx,dl
       sub       eax,edx
       ret
; Total bytes of code 20

Compare3 Release

; Program.Compare3(Char)
       movzx     eax,dx
       cmp       eax,41
       jl        short M00_L00
       cmp       eax,5A
       jle       short M00_L02
M00_L00:
       cmp       eax,61
       jl        short M00_L01
       cmp       eax,7A
       jle       short M00_L02
M00_L01:
       xor       eax,eax
       ret
M00_L02:
       mov       eax,1
       ret
; Total bytes of code 32

Compare3 ReleaseCustomRoslyn

; Program.Compare3(Char)
       movzx     eax,dx
       cmp       eax,41
       jl        short M00_L00
       cmp       eax,5A
       jle       short M00_L02
M00_L00:
       cmp       eax,61
       jl        short M00_L01
       cmp       eax,7A
       setle     al
       movzx     eax,al
       ret
M00_L01:
       xor       eax,eax
       ret
M00_L02:
       mov       eax,1
       ret
; Total bytes of code 37

src/Compilers/CSharp/Test/Emit/CodeGen/PatternTests.cs

jjonescz · 2023-03-08T10:06:18Z

src/Compilers/CSharp/Test/Emit/CodeGen/PatternTests.cs

+      IL_0018:  ldc.i4.0
+      IL_0019:  ret
+      IL_001a:  ldc.i4.1
+      IL_001b:  ret
    }
 ");
        }


Correctness_Rebuild fails with weird errors (AzDo build).

It crashes with OOM (repeatedly - can even reproduce that locally).

Details:

2023-03-07T14:25:15.5083562Z Validation failed for D:\a\_work\1\s\artifacts/obj/Microsoft.CodeAnalysis.ExpressionCompiler\Release\netstandard2.0\Microsoft.CodeAnalysis.ExpressionEvaluator.ExpressionCompiler.dll 2023-03-07T14:25:15.5084335Z Writing diffs to "D:\a\_work\1\s\artifacts\BuildValidator\netstandard2.0\Microsoft.CodeAnalysis.ExpressionEvaluator.ExpressionCompiler" 2023-03-07T14:25:16.6559691Z Exception of type 'System.OutOfMemoryException' was thrown. 2023-03-07T14:25:17.2868546Z Unhandled exception: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.BadImageFormatException: Exception of type 'System.OutOfMemoryException' was thrown. 2023-03-07T14:25:17.2912239Z at System.Reflection.PortableExecutable.PEReader.DecodeEmbeddedPortablePdbDebugDirectoryData(AbstractMemoryBlock block) 2023-03-07T14:25:17.2913380Z at System.Reflection.PortableExecutable.PEReader.ReadEmbeddedPortablePdbDebugDirectoryData(DebugDirectoryEntry entry) 2023-03-07T14:25:17.2914522Z at System.Reflection.PortableExecutable.PEReader.TryOpenEmbeddedPortablePdb(DebugDirectoryEntry embeddedPdbEntry, Boolean& openedEmbeddedPdb, MetadataReaderProvider& provider, Exception& errorToReport) 2023-03-07T14:25:17.2915533Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2916473Z at System.Reflection.PortableExecutable.PEReader.TryOpenAssociatedPortablePdb(String peImagePath, Func`2 pdbFileStreamProvider, MetadataReaderProvider& pdbReaderProvider, String& pdbPath) 2023-03-07T14:25:17.2917705Z at BuildValidator.Program.ValidateFile(Options options, AssemblyInfo assemblyInfo, ILogger logger, LocalReferenceResolver referenceResolver) in /_/src/Tools/BuildValidator/Program.cs:line 278 2023-03-07T14:25:17.2918862Z at BuildValidator.Program.ValidateFiles(IEnumerable`1 assemblyInfos, Options options, ILoggerFactory loggerFactory) in /_/src/Tools/BuildValidator/Program.cs:line 203 2023-03-07T14:25:17.2920092Z at BuildValidator.Program.HandleCommand(String[] assembliesPath, String[] exclude, String sourcePath, String[] referencesPath, Boolean verbose, Boolean quiet, Boolean debug, String debugPath) in /_/src/Tools/BuildValidator/Program.cs:line 140 2023-03-07T14:25:17.2921119Z --- End of inner exception stack trace --- 2023-03-07T14:25:17.2921791Z at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor) 2023-03-07T14:25:17.2922646Z at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments) 2023-03-07T14:25:17.2923305Z at System.Delegate.DynamicInvokeImpl(Object[] args) 2023-03-07T14:25:17.2923909Z at System.CommandLine.Invocation.ModelBindingCommandHandler.<InvokeAsync>d__12.MoveNext() 2023-03-07T14:25:17.2924532Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2925172Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2925877Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 2023-03-07T14:25:17.2926703Z at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext() 2023-03-07T14:25:17.2927388Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2928302Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2928941Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 2023-03-07T14:25:17.2929653Z at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseParseErrorReporting>b__21_0>d.MoveNext() 2023-03-07T14:25:17.2930293Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2930858Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2931547Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 2023-03-07T14:25:17.2932274Z at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<<UseHelp>b__0>d.MoveNext() 2023-03-07T14:25:17.2933007Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2933583Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2934255Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 2023-03-07T14:25:17.2935036Z at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass25_0.<<UseVersionOption>b__0>d.MoveNext() 2023-03-07T14:25:17.2935862Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2936465Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2937091Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 2023-03-07T14:25:17.2937850Z at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass23_0.<<UseTypoCorrections>b__0>d.MoveNext() 2023-03-07T14:25:17.2938507Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2939096Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2939726Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 2023-03-07T14:25:17.2940461Z at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__22_0>d.MoveNext() 2023-03-07T14:25:17.2941157Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2941704Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2942359Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 2023-03-07T14:25:17.2943033Z at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseParseDirective>b__20_0>d.MoveNext() 2023-03-07T14:25:17.2943675Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2944209Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2944873Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 2023-03-07T14:25:17.2945555Z at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseDebugDirective>b__11_0>d.MoveNext() 2023-03-07T14:25:17.2946187Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2946767Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2947395Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 2023-03-07T14:25:17.2948145Z at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__10_0>d.MoveNext() 2023-03-07T14:25:17.2948773Z --- End of stack trace from previous location where exception was thrown --- 2023-03-07T14:25:17.2949358Z at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) 2023-03-07T14:25:17.2949983Z at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Before it crashes, BuildValidator.exe also reports different IL after rebuild in test classes - seems exactly the test classes that this PR touches. Constants are emitted differently, I have no idea why.

Details:

For example, in PatternSwitchTests.DuplicateDouble:

- IL_000a: /* 23 | 40091EB851EB851F */ ldc.r8 3.1400000000000001 + IL_000a: /* 23 | 40091EB951EB851F */ ldc.r8 3.1400019073486329

In AttributeTests.TestAttributesOnPropertyAndGetSet:

@@ -2331,7 +2331,7 @@ IL_00fc: /* A2 | */ stelem.ref IL_00fd: /* 25 | */ dup IL_00fe: /* 19 | */ ldc.i4.3 - IL_00ff: /* 23 | 400921FB4D12D84A */ ldc.r8 3.1415926000000001 + IL_00ff: /* 23 | 400921FC4D12D84A */ ldc.r8 3.1415945073486329 IL_0108: /* 8C | (01)0002D0 */ box [mscorlib/*23000001*/]System.Double/*010002D0*/ + "}\r\n1.0m !\r\nnull" /* 7036B889 */ - IL_0036: /* 23 | 4000CCCCCCCCCCCD */ ldc.r8 2.1000000000000001 + IL_0036: /* 23 | 4000CCCDCCCCCCCD */ ldc.r8 2.1000019073486329 IL_003f: /* 8C | (01)0002D0 */ box [mscorlib/*23000001*/]System.Double/*010002D0*/ IL_0044: /* 22 | 40066666 */ ldc.r4 2.0999999 IL_0049: /* 8C | (01)0002D1 */ box [mscorlib/*23000001*/]System.Single/*010002D1*/ @@ -595932,7 +595932,7 @@ IL_0050: /* 8D | (01)000014 */ newarr [mscorlib/*23000001*/]System.Object/*01000014*/ IL_0055: /* 25 | */ dup IL_0056: /* 16 | */ ldc.i4.0 - IL_0057: /* 23 | 3FF028F5C28F5C29 */ ldc.r8 1.01 + IL_0057: /* 23 | 3FF028F6C28F5C29 */ ldc.r8 1.0100009536743164 IL_0060: /* 0D | */ stloc.3 IL_0061: /* 12 | 03 */ ldloca.s V_3 IL_0063: /* 28 | (0A)0005CA */ call instance string [mscorlib/*23000001*/]System.Double/*010002D0*/::ToString() /* 0A0005CA */

Let me try debugging that this morning and see if I come up with anything.

Okay I figured out the OOM issue. The OOM is coming from a call to AllocHGlobal deep inside the PEStream loading code. The problem with AllocHGlobal is that it's a native memory allocation function and hence doesn't represent any type of pressure to the GC. While we have memory available here, it's just not collected, there isn't enough to satisfy the 41MB request that happens because allocating native memory doesn't pressure the GC to do a collect.

I believe this is happening in your case because the earlier failures in the execution cause more memory to get loaded (to dump XML, MDV, etc ...). That pushes us over the limit and causes a crash.

Short term I fixed this by just making the app run as 64 bit locally. Still looking at the actual errors.

Pushed a test change to your PR and yes that fixed the issue. Will open a separate PR for that but will keep it here so it's not blocking you.

Thanks for fixing the OOM. I see that the BuildValidator doesn't report any IL differences anymore - is that expected? I thought those two failures were unrelated, but maybe not.

This process uses a significant amount of memory as it's essentially doing compilation. Like the compiler server it needs to be 64 bit on 64 platforms to safely host all the items. Moved to explicit PlatformTarget of AnyCPU so it's not silently run as x86 in Debug.

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs

src/Compilers/CSharp/Test/Emit/CodeGen/PatternTests.cs

RikkiGibson · 2023-03-08T23:08:26Z

I didn't understand some of the before/after assembly code in the PR description. For example, it looks like the Compare1 before and after are the same, but the performance is different.

AndyAyersMS · 2023-03-09T02:33:49Z

@jjonescz which runtime version were you benchmarking above?

jjonescz · 2023-03-09T10:20:31Z

which runtime version were you benchmarking above?

It was .NET 7. I added .NET 8 - but it seems the ASM is the same for this benchmark.

I didn't understand some of the before/after assembly code in the PR description. For example, it looks like the Compare1 before and after are the same, but the performance is different.

You're right, Compare1 is weird - it has the same IL and assembly (that's expected) - but execution times are different. I excluded it from the results for now.

jjonescz · 2023-03-10T14:13:29Z

Updated benchmarks - the problem was having constant parameters - I randomized them. Also run them in a DevBox to avoid interference with my other work.

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenConditionalOperatorTests.cs

src/Compilers/CSharp/Test/Emit/CodeGen/PatternTests.cs

AlekseyTs · 2023-03-10T16:02:02Z

I think we should split the infrastructure changes into its own PR.

src/Compilers/CSharp/Test/Emit/CodeGen/PatternTests.cs

AlekseyTs · 2023-03-10T16:11:18Z

Done with review pass (commit 5)

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs

jjonescz · 2023-03-13T08:53:27Z

I think we should split the infrastructure changes into its own PR.

It's in #67240.

src/Compilers/VisualBasic/Portable/CodeGen/EmitOperators.vb

src/Compilers/CSharp/Portable/CodeGen/EmitOperators.cs

AlekseyTs · 2023-03-21T12:59:16Z

Done with review pass (commit 27)

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs

AlekseyTs

LGTM (commit 28), modulo the parameter name/documentation.

TIHan

From the JIT side, we believe this will not cause perf regressions from older JITs - should be fine to do.

jjonescz · 2023-04-12T09:00:36Z

@dotnet/roslyn-compiler for a second review, please

jcouv · 2023-04-12T15:48:49Z

src/Compilers/CSharp/Portable/CodeGen/EmitOperators.cs

@@ -506,6 +500,64 @@ private void EmitCondExpr(BoundExpression condition, bool sense)
            return;
        }

+        /// <summary>
+        /// Emits boolean expression without branching if possible (i.e., no logical operators, only comparisons).
+        /// Leaves a boolean (int32) value on the stack which conforms to sense, i.e., <c>condition == sense</c>.


May be worth mentioning that the resulting value is either 0 or 1 only. #Closed

jcouv · 2023-04-12T15:50:24Z

src/Compilers/CSharp/Portable/CodeGen/EmitOperators.cs

+                EmitIsExpression(isOp, used: true, omitBooleanConversion: true);
+
+                // Convert to 1 or 0.
+                _builder.EmitOpCode(ILOpCode.Ldnull);


I didn't follow why we're pushing ldnull here, but ldc_i4_0 below (line 543). When do we need to use one versus the other? #Closed

Never mind, I found out. EmitIsExpression uses Isinst which returns "either a null reference or an instance of that class or interface."

jcouv · 2023-04-12T15:56:39Z

src/Compilers/CSharp/Portable/CodeGen/EmitOperators.cs

+            }
+            else if (condition is BoundIsOperator isOp)
+            {
+                EmitIsExpression(isOp, used: true, omitBooleanConversion: true);


nit: EmitIsExpression can already emit the ldnull and cgt_un. Did you consider adding a sense parameter (which would drive cgt_un or ceq) instead of an omitBooleanConversion parameter?
Update: I see that the current design allows to keep C# and VB changes more similar. Fine to keep as-is #Closed

jcouv · 2023-04-12T16:00:17Z

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs

+            {
+                if (expr.ConstantValueOpt is { } constantValue)
+                {
+                    if (constantValue is { IsIntegral: true, UInt64Value: (1 or 0) and var v })


v

nit: I don't love the single-letter variable names, but in this code it's not too bad (each is only used once). But consider naming this one i ;-) #Closed

jcouv · 2023-04-12T16:02:14Z

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs

@@ -3483,6 +3487,22 @@ private void EmitConditionalOperator(BoundConditionalOperator expr, bool used)
        {
            Debug.Assert(expr.ConstantValueOpt == null, "Constant value should have been emitted directly");

+            // Generate branchless IL for (b ? 1 : 0).
+            if (used && _ilEmitStyle != ILEmitStyle.Debug &&
+                (IsNumeric(expr.Type) || expr.Type.PrimitiveTypeCode == Cci.PrimitiveTypeCode.Boolean) &&


IsNumeric(expr.Type)

Do we have tests for each of the numeric types? #Resolved

Yes, here:

roslyn/src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenConditionalOperatorTests.cs

Lines 125 to 137 in e9aca83

Write(x <= y ? true : false);

Write(x <= y ? false : true);

Write(x != y ? (byte)1 : (byte)0);

Write(x != y ? 1 : (sbyte)0);

Write(x != y ? (short)1 : (short)0);

Write(x != y ? (ushort)1 : 0);

Write(x != y ? 1U : 0);

Write(x != y ? 1L : 0);

Write(x != y ? 1UL : 0);

Write(x != y ? (nint)1 : 0);

Write(x != y ? 1 : (nuint)0);

Write(x < y ? (char)0 : (char)1);

Write(x < y ? '\x1' : '\x0');

jcouv · 2023-04-12T16:03:09Z

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs

@@ -3483,6 +3487,22 @@ private void EmitConditionalOperator(BoundConditionalOperator expr, bool used)
        {
            Debug.Assert(expr.ConstantValueOpt == null, "Constant value should have been emitted directly");

+            // Generate branchless IL for (b ? 1 : 0).
+            if (used && _ilEmitStyle != ILEmitStyle.Debug &&


_ilEmitStyle != ILEmitStyle.Debug

You mentioned DebugFriendlyRelease earlier. Do we have a test for that emit style? #Resolved

jcouv · 2023-04-12T17:34:09Z

src/Compilers/VisualBasic/Test/Emit/CodeGen/CodeGenIfOperator.vb

@@ -15,6 +15,567 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.UnitTests
    Public Class CodeGenIfOperator
        Inherits BasicTestBase

+        <Fact, WorkItem(61483, "https://github.com/dotnet/roslyn/issues/61483")>


Consider also testing with IntPtr in VB (optimization should not kick in, unlike C# in some cases) #Resolved

jcouv

Done with review pass (iteration 29). Only some test suggestions to consider

jcouv

LGTM Thanks (iteration 33)

dotnet-issue-labeler bot added the Area-Compilers label Mar 6, 2023

jjonescz force-pushed the 61483-Emit-cgt branch from cf470ac to cec99f4 Compare March 6, 2023 16:19

jjonescz added 3 commits March 7, 2023 17:06

Add tests

26b944a

Generate branchless IL for (b ? 1 : 0)

e2c3f4d

Update IL snapshots

01f7f64

jjonescz force-pushed the 61483-Emit-cgt branch from cec99f4 to 01f7f64 Compare March 7, 2023 16:06

jjonescz commented Mar 8, 2023

View reviewed changes

jjonescz marked this pull request as ready for review March 8, 2023 10:08

jjonescz requested a review from a team as a code owner March 8, 2023 10:08

jaredpar requested a review from a team as a code owner March 8, 2023 22:14

jaredpar reviewed Mar 8, 2023

View reviewed changes

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs Outdated Show resolved Hide resolved

src/Compilers/CSharp/Test/Emit/CodeGen/PatternTests.cs Outdated Show resolved Hide resolved

jaredpar mentioned this pull request Mar 9, 2023

Remove some outdated configurations in tools #52800

Merged

Rename isOne out parameter

1fe26ef

This was referenced Mar 9, 2023

AlignOpenBraceWithMethodDeclaration is flaky #67244

Closed

VerifyLocalVariableRename is flaky #67245

Closed

AlekseyTs reviewed Mar 10, 2023

View reviewed changes

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs Show resolved Hide resolved

AlekseyTs reviewed Mar 10, 2023

View reviewed changes

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs Outdated Show resolved Hide resolved

AlekseyTs reviewed Mar 10, 2023

View reviewed changes

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenConditionalOperatorTests.cs Show resolved Hide resolved

AlekseyTs reviewed Mar 10, 2023

View reviewed changes

src/Compilers/CSharp/Test/Emit/CodeGen/PatternTests.cs Outdated Show resolved Hide resolved

AlekseyTs reviewed Mar 10, 2023

View reviewed changes

src/Compilers/CSharp/Test/Emit/CodeGen/PatternTests.cs Outdated Show resolved Hide resolved

AlekseyTs reviewed Mar 10, 2023

View reviewed changes

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs Outdated Show resolved Hide resolved

Add nonbinary test

87a5313

Optimize isinst

857b0c4

AlekseyTs reviewed Mar 21, 2023

View reviewed changes

src/Compilers/VisualBasic/Portable/CodeGen/EmitOperators.vb Show resolved Hide resolved

AlekseyTs reviewed Mar 21, 2023

View reviewed changes

src/Compilers/CSharp/Portable/CodeGen/EmitOperators.cs Outdated Show resolved Hide resolved

Optimize is codegen when used inside condition

1f0cc3a

AlekseyTs reviewed Mar 21, 2023

View reviewed changes

src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs Outdated Show resolved Hide resolved

AlekseyTs approved these changes Mar 21, 2023

View reviewed changes

Rename parameter which omits boolean conversion of is codegen

e9aca83

TIHan approved these changes Mar 27, 2023

View reviewed changes

jcouv reviewed Apr 12, 2023

View reviewed changes

jcouv self-assigned this Apr 12, 2023

jjonescz added 4 commits April 14, 2023 10:38

Clarify return values

f2c8d13

Improve variable naming

be1432c

Test IntPtr in VB

d202e2b

Test ILEmitStyle.DebugFriendlyRelease

c3e6928

jcouv approved these changes Apr 14, 2023

View reviewed changes

Merge branch 'main' into 61483-Emit-cgt

72b4890

jjonescz merged commit 009407d into dotnet:main Apr 17, 2023
26 checks passed

jjonescz deleted the 61483-Emit-cgt branch April 17, 2023 14:54

allisonchou mentioned this pull request Apr 18, 2023

[Automated] PRs inserted in VS build main-33618.212 #67866

Closed

DoctorKrolic mentioned this pull request Oct 1, 2023

Compiler should optimize conversion from boolean to integer #36625

Closed

alrz mentioned this pull request Oct 12, 2023

Utilize ConstantValueOne while emitting conditionals #70352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate branchless IL for `(b ? 1 : 0)` #67191

Generate branchless IL for `(b ? 1 : 0)` #67191

jjonescz commented Mar 6, 2023 •

edited

jjonescz Mar 8, 2023 •

edited

jaredpar Mar 8, 2023

jaredpar Mar 8, 2023

jaredpar Mar 8, 2023

jjonescz Mar 9, 2023

RikkiGibson commented Mar 8, 2023

AndyAyersMS commented Mar 9, 2023

jjonescz commented Mar 9, 2023

jjonescz commented Mar 10, 2023 •

edited

AlekseyTs commented Mar 10, 2023

AlekseyTs commented Mar 10, 2023

jjonescz commented Mar 13, 2023

AlekseyTs commented Mar 21, 2023

AlekseyTs left a comment

TIHan left a comment

jjonescz commented Apr 12, 2023

jcouv Apr 12, 2023 •

edited

jcouv Apr 12, 2023 •

edited

jcouv Apr 12, 2023

jcouv Apr 12, 2023 •

edited

jcouv Apr 12, 2023 •

edited

jcouv Apr 12, 2023 •

edited by jjonescz

jjonescz Apr 14, 2023

jcouv Apr 12, 2023 •

edited by jjonescz

jjonescz Apr 14, 2023

jcouv Apr 12, 2023 •

edited by jjonescz

jcouv left a comment

jcouv left a comment

	Write(x <= y ? true : false);
	Write(x <= y ? false : true);
	Write(x != y ? (byte)1 : (byte)0);
	Write(x != y ? 1 : (sbyte)0);
	Write(x != y ? (short)1 : (short)0);
	Write(x != y ? (ushort)1 : 0);
	Write(x != y ? 1U : 0);
	Write(x != y ? 1L : 0);
	Write(x != y ? 1UL : 0);
	Write(x != y ? (nint)1 : 0);
	Write(x != y ? 1 : (nuint)0);
	Write(x < y ? (char)0 : (char)1);
	Write(x < y ? '\x1' : '\x0');

Generate branchless IL for (b ? 1 : 0) #67191

Generate branchless IL for (b ? 1 : 0) #67191

Conversation

jjonescz commented Mar 6, 2023 • edited

Benchmarks (source)

Compare2 Release

Compare2 ReleaseCustomRoslyn

Compare3 Release

Compare3 ReleaseCustomRoslyn

jjonescz Mar 8, 2023 • edited

Choose a reason for hiding this comment

jaredpar Mar 8, 2023

Choose a reason for hiding this comment

jaredpar Mar 8, 2023

Choose a reason for hiding this comment

jaredpar Mar 8, 2023

Choose a reason for hiding this comment

jjonescz Mar 9, 2023

Choose a reason for hiding this comment

RikkiGibson commented Mar 8, 2023

AndyAyersMS commented Mar 9, 2023

jjonescz commented Mar 9, 2023

jjonescz commented Mar 10, 2023 • edited

AlekseyTs commented Mar 10, 2023

AlekseyTs commented Mar 10, 2023

jjonescz commented Mar 13, 2023

AlekseyTs commented Mar 21, 2023

AlekseyTs left a comment

Choose a reason for hiding this comment

TIHan left a comment

Choose a reason for hiding this comment

jjonescz commented Apr 12, 2023

jcouv Apr 12, 2023 • edited

Choose a reason for hiding this comment

jcouv Apr 12, 2023 • edited

Choose a reason for hiding this comment

jcouv Apr 12, 2023

Choose a reason for hiding this comment

jcouv Apr 12, 2023 • edited

Choose a reason for hiding this comment

jcouv Apr 12, 2023 • edited

Choose a reason for hiding this comment

jcouv Apr 12, 2023 • edited by jjonescz

Choose a reason for hiding this comment

jjonescz Apr 14, 2023

Choose a reason for hiding this comment

jcouv Apr 12, 2023 • edited by jjonescz

Choose a reason for hiding this comment

jjonescz Apr 14, 2023

Choose a reason for hiding this comment

jcouv Apr 12, 2023 • edited by jjonescz

Choose a reason for hiding this comment

jcouv left a comment

Choose a reason for hiding this comment

jcouv left a comment

Choose a reason for hiding this comment

Generate branchless IL for `(b ? 1 : 0)` #67191

Generate branchless IL for `(b ? 1 : 0)` #67191

jjonescz commented Mar 6, 2023 •

edited

jjonescz Mar 8, 2023 •

edited

jjonescz commented Mar 10, 2023 •

edited

jcouv Apr 12, 2023 •

edited

jcouv Apr 12, 2023 •

edited

jcouv Apr 12, 2023 •

edited

jcouv Apr 12, 2023 •

edited

jcouv Apr 12, 2023 •

edited by jjonescz

jcouv Apr 12, 2023 •

edited by jjonescz

jcouv Apr 12, 2023 •

edited by jjonescz