Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add review comment to sb files #68409

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

oleksandr-didyk
Copy link
Contributor

Contributes to dotnet/source-build#3435

Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter SourceBuild* files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))

@oleksandr-didyk oleksandr-didyk requested a review from a team as a code owner June 1, 2023 13:05
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 1, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jun 1, 2023
@333fred
Copy link
Member

333fred commented Jun 1, 2023

Rather than comments, please update the CODEOWNERS file to include the relevant files and the source build team, so that it automatically includes you on such PRs.

@oleksandr-didyk
Copy link
Contributor Author

Rather than comments, please update the CODEOWNERS file to include the relevant files and the source build team, so that it automatically includes you on such PRs.

Initially wanted to add both the comment and the CODEOWNERS entry, but for a team to be added as a code owner it needs to have write permissions to the repo and I wanted to verify first if this is something we would need. I should've mentioned that in the description though, my bad, forgot to edit it.

If you are OK with granting write permissions to dotnet/source-build-internal, I will add the CODEOWNERS entry.

@oleksandr-didyk
Copy link
Contributor Author

@333fred soft ping - would write access to the team be considered as an option or can we move on with merging this PR as is? Thank you!

@333fred
Copy link
Member

333fred commented Jun 12, 2023

@oleksandr-didyk write access for dotnet/source-build-internal has been added.

@oleksandr-didyk
Copy link
Contributor Author

@oleksandr-didyk write access for dotnet/source-build-internal has been added.

Thank you!

Added the CODEOWNERS entry for source-build

@333fred 333fred enabled auto-merge (squash) June 13, 2023 18:22
@333fred 333fred merged commit 84fa8e1 into dotnet:main Jun 13, 2023
27 checks passed
@ghost ghost added this to the Next milestone Jun 13, 2023
@RikkiGibson RikkiGibson modified the milestones: Next, 17.7 P3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants