Fix LSIF indexing handling of duplicate analyzer references #68423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LSIF tool supports many types of inputs, but two in particular: 1. A JSON file that contains the command line arguments passed to the compiler. 2. A binlog which will be searched for invocations. When the binlog support was implemented, it called into the implementation for JSON files to do the heavy lifting of actually parsing the command line. But oddly, that code somewhat reinvented the implementation of our CommandLineProject type, so it could also support some specific path mapping logic. Unfortunately implementation for JSON inputs has a bunch of bugs that don't exist in the CommandLineProject code Specifically, duplicate analyzer references are not correctly handled which triggered this investigation. In this commit, I'm fixing some bugs in CommandLineProject and then making the binlog code just directly call into CommandLineProject which removes the buggy code for processing JSON inputs from the binlog path. As a follow up, we should either also move the JSON input handling to CommandLineProject after adding path mapping support to it, or just deprecate that support entirely.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
changed the title
jasonmalinowski
changed the title
genlu
reviewed
Jun 2, 2023
| hostObjectType: null); | ||
|
|
||
| return projectInfo; | ||
|
|
||
| IList<DocumentInfo> CreateDocuments(ImmutableArray<CommandLineSourceFile> files) |
There was a problem hiding this comment.
Is this just extracting the helper and additionally uses it for analyzerConfigDocuments? Is there other changes in how those documents are created?
There was a problem hiding this comment.
@genlu: yeah for some reason it was copied/pasted for additional files. The only change I saw was special handling around regular/script, but since the compiler's inputs will just count additional files as "regular" that wouldn't be a problem in the first place.
jasonmalinowski
deleted the
fix-lsif-indexing-handling-of-duplicate-references
branch
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSIF tool supports many types of inputs, but two in particular:
When the binlog support was implemented, it called into the implementation for JSON files to do the heavy lifting of actually parsing the command line. But oddly, that code somewhat reinvented the implementation of our CommandLineProject type, so it could also support some specific path mapping logic. Unfortunately implementation for JSON inputs has a bunch of bugs that don't exist in the CommandLineProject code. Specifically, duplicate analyzer references are not correctly handled which triggered this investigation.
In this commit, I'm fixing some bugs in CommandLineProject and then making the binlog code just directly call into CommandLineProject which removes the buggy code for processing JSON inputs from the binlog path. As a follow up, we should either also move the JSON input handling to CommandLineProject after adding path mapping support to it, or just deprecate that support entirely.