Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MacOS on PRs #68470

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Disable MacOS on PRs #68470

merged 1 commit into from
Jun 7, 2023

Conversation

jaredpar
Copy link
Member

@jaredpar jaredpar commented Jun 7, 2023

Our PRs already run tests on Unix which is a sufficient proxy for Mac runs. Can leave Mac as CI only and slim down our PR runs

Our PRs already run tests on Unix which is a sufficient proxy for Mac
runs. Can leave Mac as CI only and slim down our PR runs
@jaredpar jaredpar requested a review from a team as a code owner June 7, 2023 16:26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 7, 2023
@RikkiGibson
Copy link
Contributor

It was at least true at one time that Mac runs queued much faster than Linux. Do we know the state of that now?

@jaredpar
Copy link
Member Author

jaredpar commented Jun 7, 2023

It was at least true at one time that Mac runs queued much faster than Linux. Do we know the state of that now?

It runs faster but has far less capacity. This means when you measure CI / PR time switching from Unix to Mac you almost always see a win. But when you actually commit it a few days later you will see a loss. That cause a single PR doesn't stress the capacity issue but the weight of our dev team does. It's a lesson several of the repos have learned at this point.

The other issues with Mac:

  • The queue itself has more frequent outages than Unix
  • Not as many teams depend on it hence it has lower priority when things are broken. Contrarily when Unix is down the .NET world is down so no need for us to push on a "please fix" cause literally everyone else is.

@jaredpar jaredpar merged commit 4ab792a into dotnet:main Jun 7, 2023
20 of 24 checks passed
@jaredpar jaredpar deleted the infra branch June 7, 2023 18:37
@ghost ghost added this to the Next milestone Jun 7, 2023
@RikkiGibson RikkiGibson modified the milestones: Next, 17.7 P3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants