Point manual publishing to public feed #68558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
333fred
reviewed
Jun 12, 2023
| @@ -317,8 +317,9 @@ stages: | |||
| command: push | |||
| packagesToPush: '$(Build.SourcesDirectory)\artifacts\LanguageServer\*.nupkg' | |||
| allowPackageConflicts: false | |||
| feedsToUse: select | |||
There was a problem hiding this comment.
This is documented as the default?
There was a problem hiding this comment.
yeah I don't need specify this value. However CI passed on this commit and I have another PR out to delete this entire step (as soon as dnceng helps me fix signing) - #68504
So going to leave this as-is for expediency
jasonmalinowski
approved these changes
Jun 12, 2023
| nuGetFeedType: external | ||
| publishFeedCredentials: 'DevDiv - VS package feed' | ||
| publishFeedCredentials: 'azure-public/vs-impl' |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on enabling our normal publishing flow for this package (see #68504), but there are some issues around signing. I'm working with dnceng to get those resolved, but in the meantime this should unblock consumption of the packages in vscode-csharp.
Test build - https://dnceng.visualstudio.com/internal/_build/results?buildId=2198741&view=results