Upgrade NuGet.Frameworks to fix loading projects with the 7.0.4xx SDK #69354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
arkalyanms
approved these changes
Aug 3, 2023
|
Another patch candidate. cc: @dibarbet |
The 7.0.4xx SDKs ship with a newer version of NuGet.Frameworks than we are shipping. Due to a complicated set of interactions of how the various AssemblyLoadingContexts work (or don't work as expected!), this means that when our LSP server uses MSBuildWorkspace to load projects, it'll end up using the NuGet.Frameworks we use here rather than the MSBuild one, causing load issues. The underlying problem is tracked with dotnet#61454, although I still need to write up the full situation in that bug since back in June we ended up running into a similar issue and had lots of deep analysis of it. Fixing the problem requires changes in several different repositories (and all involving AssemblyLoadContexts, so the changes are very technical) so for now we'll just bump the version. Fixes dotnet/vscode-csharp#5980
jasonmalinowski
force-pushed
the
bump-nuget-version
branch
from
0446916
to
189b483
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 7.0.4xx SDKs ship with a newer version of NuGet.Frameworks than we are shipping. Due to a complicated set of interactions of how the various AssemblyLoadingContexts work (or don't work as expected!), this means that when our LSP server uses MSBuildWorkspace to load projects, it'll end up using the NuGet.Frameworks we use here rather than the MSBuild one, causing load issues.
The underlying problem is tracked with #61454, although I still need to write up the full situation in that bug since back in June we ended up running into a similar issue and had lots of deep analysis of it. Fixing the problem requires changes in several different repositories (and all involving AssemblyLoadContexts, so the changes are very technical) so for now we'll just bump the version.
Fixes dotnet/vscode-csharp#5980