Upgrade MSBuildLocator to 1.6.1 #69769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version should better discover MSBuild on some Mac machines that have .NET installed by Homebrew.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
I think this also fixes |
dibarbet
approved these changes
Aug 30, 2023
|
@dibarbet Ah right, I thought there was more. |
333fred
approved these changes
Aug 30, 2023
ghost
added this to the 
|
This change requires the MSBuildLocator submodule to be updated in source-build-externals. @jasonmalinowski, could you take care of that please? Instructions for doing that are here. Source-build is currently building version 1.5.5 of MSBuildLocator. So updating the referenced version to 1.6.1 here is causing prebuilts to be introduced, as mentioned in #69847. |
|
@mthalman I'm following up with the repository owners to figure out who should do it. |
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version should better discover MSBuild on some Mac machines that have .NET installed by Homebrew.
Fixes dotnet/vscode-csharp#6063
Fixes dotnet/vscode-csharp#6253
Fixes dotnet/vscode-csharp#6122
Fixes dotnet/vscode-csharp#6198