Ensure the VSCode server process runs on non-preview runtime #70446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
requested changes
Oct 18, 2023
src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs
Outdated
Show resolved
Hide resolved
dibarbet
force-pushed
the
remove_runtime_framework_version
branch
from
339ff83
to
69af321
Compare
Co-authored-by: Jason Malinowski <jason@jason-m.com>
…ver/Program.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>
jasonmalinowski
approved these changes
Oct 19, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change
Removes the
RuntimeFrameworkVersionspecified in the VSCode language server process (and adds logging as to which dotnet runtime the server and build host process are running on)Why we specified
RuntimeFrameworkVersionin the pastSpecifying the
RuntimeFrameworkVersionwas an old hack that allowed the main server process to roll forward to run on preview runtimes. This was required to be able to load some projects using preview SDKs.Why we don't need
RuntimeFrameworkVersionnowWe now launch a separate build host process with roll forward
LatestMajorandDOTNET_ROLL_FORWARD_TO_PRERELEASEto1. This will allow the build host to run and load the project on preview runtimes. It is not necessary for our main server process to run on preview runtimes.Why this is changing now
Setting
RuntimeFrameworkVersionto a preview version causes the language server to prefer to run on a preview version of .NET 7, even when a non-preview version of .NET 7 is installed.This causes the exceptions noted in dotnet/vscode-csharp#6479 because the version of
System.Text.Jsonin the .NET 7 Preview 7 SDK is missing theJsonRequiredAttribute. But the copy ofNewtonsoft.Jsonin the server is expecting it to be present (and it is available in non-preview versions of .NET 7).Note: if only a preview version of .NET 7 is installed it won't match our runtime version requirement and we will download a non-preview .NET 7 runtime (via the runtime installer extension).
Resolves dotnet/vscode-csharp#6479