Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSBuild.StructuredLogger #71576

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

JanKrivanek
Copy link
Member

FYI @KirillOsenkov

Context

This is update to the latest version of MSBuild.StructuredLogger, that contains the forward compatibility reading support.
The initial MSBuild change to forward compatible logs reading is breaking (log data format needs to be adjusted in order to allow forward compatibile reading for the future) - hence updating the reading code ahead of MSBuild pushing the updated version of binlog writing (dotnet/msbuild#9307) is advisable.

@JanKrivanek JanKrivanek requested a review from a team as a code owner January 11, 2024 11:00
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 11, 2024
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jan 11, 2024
@JanKrivanek
Copy link
Member Author

Job pushing the new version of MSBuild.StructuredLogger to dotnet-public: https://dev.azure.com/dnceng/internal/_build/results?buildId=2351338&view=results

@JanKrivanek
Copy link
Member Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 71576 in repo dotnet/roslyn

@JanKrivanek
Copy link
Member Author

Can anyone rerun the pipeline? The missed package is already in the feed

> curl https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/MSBuild.StructuredLogger/index.json

(...)
Content           : {"versions":["2.2.158","2.2.155",(...)
(...)

@KirillOsenkov
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@JanKrivanek
Copy link
Member Author

The failing test (Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpClassification.SemanticClassification) seem to be quite unstable - should it be disabled untill fixed?

image

@JanKrivanek
Copy link
Member Author

@genlu is the Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpClassification.SemanticClassification being looked on?
I was hoping to get this PR merged soon so that we can proceeding with inserting the msbuild change in .NET9 P1

@jasonmalinowski
Copy link
Member

@JanKrivanek The failing leg can be ignored at the moment; I think it might have only triggered due to the other /azp command that was given -- this is fine to merge assuming you're ready.

@JanKrivanek
Copy link
Member Author

@jasonmalinowski - thanks for details! Yes, it's ready :-)

@jasonmalinowski jasonmalinowski merged commit 9c12d5d into dotnet:main Jan 12, 2024
31 of 34 checks passed
@ghost ghost added this to the Next milestone Jan 12, 2024
@JanKrivanek JanKrivanek deleted the patch-1 branch January 15, 2024 09:02
@Cosifne Cosifne modified the milestones: Next, 17.10 P1 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants