Hande error scenarios involving target types and named arguments in nullable walker #72635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jaredpar
approved these changes
Mar 22, 2024
RikkiGibson
reviewed
Mar 22, 2024
| parameter is null || | ||
| // In error recovery with named arguments, target-typing cannot work as we can get a different parameter type | ||
| // from our GetCorrespondingParameter logic than Binder.BuildArgumentsForErrorRecovery does. | ||
| node is BoundCall { HasErrors: true, ArgumentNamesOpt.IsDefaultOrEmpty: false, ArgsToParamsOpt.IsDefault: true }) |
There was a problem hiding this comment.
Could you explain why we want ArgsToParamsOpt to be default in order to enter this path?
There was a problem hiding this comment.
If it's not default it means we know the args-to-params mapping so we can continue. The problem is only in error scenarios where the bad BoundCall does not contain the mapping even though there are named arguments in the call. That's when we want to enter this path to skip further processing.
There was a problem hiding this comment.
I'm going to merge before the snap. Will follow up if you have more comments. Thanks.
cston
approved these changes
Mar 25, 2024
jjonescz
added
the
New Language Feature - Nullable Reference Types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72541.