Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call IsBetterCollectionExpressionConversion for identical collection types. #72706

Merged
merged 1 commit into from
Mar 25, 2024

Do not call `IsBetterCollectionExpressionConversion` for identical co…

1fd4f55
Select commit
Loading
Failed to load commit list.
Merged

Do not call IsBetterCollectionExpressionConversion for identical collection types. #72706

Do not call `IsBetterCollectionExpressionConversion` for identical co…
1fd4f55
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis succeeded Mar 25, 2024 in 0s

.NET Result Analysis

Details

All checks completed

[roslyn-CI]

Build Rerun

✔️ Build passed after 1 retries.

(Attempt #1) [link to build]

roslyn-CI / Windows_Debug_Desktop / Test_Windows_Desktop_Debug_64 / Run Unit Tests

[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
    ❌(NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed
    ❌PowerShell exited with code '1'.

Non-Deterministic Test Failures Detected

Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests_Microsoft.VisualStudio.LanguageServices.LiveShare.UnitTests_Microsoft.VisualStudio.LanguageSe..._78.WorkItemExecution [Console] [Details] [Artifacts] [7.58% failure rate]
[ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]
This is a helix work item crash with status: BadExit. To investigate look the [Console log] / navigate to [Helix Artifacts]

Failing Configuration

Microsoft.VisualStudio.LanguageServices.UnitTests.CodeModel.CSharp.RootCodeModelTests.TestCodeTypeFromFullName_Generated_NonGenerated [Console] [Details] [Artifacts] [2.47% failure rate]
[ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

Failing Configuration

Exception Message
System.NullReferenceException : Object reference not set to an instance of an object.
CallStack
   at Microsoft.VisualStudio.LanguageServices.Implementation.CodeModel.CodeModelProjectCache.GetOrCreateFileCodeModel(String filePath) in /_/src/VisualStudio/Core/Impl/CodeModel/CodeModelProjectCache.cs:line 84
   at Microsoft.VisualStudio.LanguageServices.Implementation.CodeModel.ProjectCodeModel.GetOrCreateFileCodeModel(String filePath) in /_/src/VisualStudio/Core/Impl/CodeModel/ProjectCodeModel.cs:line 95
   at Microsoft.VisualStudio.LanguageServices.Implementation.CodeModel.ProjectCodeModelFactory.GetOrCreateFileCodeModel(ProjectId id, String filePath) in /_/src/VisualStudio/Core/Impl/CodeModel/ProjectCodeModelFactory.cs:line 226
   at Microsoft.VisualStudio.LanguageServices.Implementation.ProjectSystem.VisualStudioWorkspaceImpl.GetFileCodeModel(DocumentId documentId) in /_/src/VisualStudio/Core/Def/ProjectSystem/VisualStudioWorkspaceImpl.cs:line 311
   at Microsoft.VisualStudio.LanguageServices.Implementation.CodeModel.AbstractCodeModelService.TryGetElementFromSource(CodeModelState state, Project project, ITypeSymbol typeSymbol, CodeElement& element) in /_/src/VisualStudio/Core/Impl/CodeModel/AbstractCodeModelService.cs:line 621
   at Microsoft.VisualStudio.LanguageServices.Implementation.CodeModel.AbstractCodeModelService.CreateCodeType(CodeModelState state, ProjectId projectId, ITypeSymbol typeSymbol) in /_/src/VisualStudio/Core/Impl/CodeModel/AbstractCodeModelService.cs:line 284
   at Microsoft.VisualStudio.LanguageServices.Implementation.CodeModel.RootCodeModel.CodeTypeFromFullName(String name) in /_/src/VisualStudio/Core/Impl/CodeModel/RootCodeModel.cs:line 149
   at EnvDTE80.CodeModel2.CodeTypeFromFullName(String Name)
   at Microsoft.VisualStudio.LanguageServices.UnitTests.CodeModel.AbstractRootCodeModelTests._Closure$__9-0._Lambda$__0(CodeModel2 rootCodeModel) in /_/src/VisualStudio/Core/Test/CodeModel/AbstractRootCodeModelTests.vb:line 83
   at Microsoft.VisualStudio.LanguageServices.UnitTests.CodeModel.AbstractRootCodeModelTests.TestRootCodeModel(XElement workspaceDefinition, Action`1 action) in /_/src/VisualStudio/Core/Test/CodeModel/AbstractRootCodeModelTests.vb:line 16
   at Microsoft.VisualStudio.LanguageServices.UnitTests.CodeModel.AbstractRootCodeModelTests.TestCodeTypeFromFullName(XElement workspaceDefinition, String fullName, Action`1 action) in /_/src/VisualStudio/Core/Test/CodeModel/AbstractRootCodeModelTests.vb:line 81
   at Microsoft.VisualStudio.LanguageServices.UnitTests.CodeModel.CSharp.RootCodeModelTests.TestCodeTypeFromFullName_Generated_NonGenerated() in /_/src/VisualStudio/Core/Test/CodeModel/CSharp/RootCodeModelTests.vb:line 291

Was this helpful? Yes No