Revert "Avoid creating result temp for is-expressions (#72273)" #72827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 00c20fc.
dotnet-issue-labeler
bot
added
the
untriaged
|
Cursed. I'm gonna leave that change to you guys if you decide to come back to it. (looks like it happens with await in finally, has nothing to do with dynamic). edit: out of curiosity I took a peek at the issue, for one, the compiler does not expect labels in expressions so this wouldn't be a small fix. |
AlekseyTs
approved these changes
Apr 1, 2024
|
Retargeted this revert PR to |
|
@dotnet/roslyn-compiler for second sign-off. Thanks |
jaredpar
approved these changes
Apr 2, 2024
jcouv
added a commit
to jcouv/roslyn
that referenced
this pull request
Apr 2, 2024
…dotnet#72827) This reverts commit 00c20fc.
jaredpar
pushed a commit
that referenced
this pull request
Apr 2, 2024
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Apr 3, 2024
* upstream/main: (416 commits) Semantic search (dotnet#71268) Make more static Fix MEF import of IExternalCSharpCopilotCodeAnalysisService to allow null Make static Make private Add comments Add method name to TimeInQueue telemetry (dotnet#72841) switch to frozen Simplify Add test Downstream Use singular helper when creating checksumsw Use singular helper when creating checksumsw Remove ability for a project to change its language Revert "Avoid creating result temp for is-expressions (dotnet#72273)" (dotnet#72827) Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2420199 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2420199 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2420199 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2420199 Improve generic type argument list error recovery (dotnet#69734) ...
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 00c20fc from PR #72273
The change caused a regression (compiler crash, issue #72753) but we won't have time to investigate for 17.10, so need to revert the change.
We'll need to re-open issues #59615 and #55334
DevDiv issue for QB mode: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2014915
FYI @alrz