Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.8 to release/dev17.9 #73236

Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev17.8 into release/dev17.9.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.8-to-release/dev17.9
git reset --hard upstream/release/dev17.9
git merge upstream/release/dev17.8
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.8-to-release/dev17.9 --force

@dotnet-bot dotnet-bot requested a review from a team as a code owner April 25, 2024 18:02
@dotnet-bot dotnet-bot force-pushed the merges/release/dev17.8-to-release/dev17.9 branch from d97948c to de75b3c Compare April 25, 2024 18:02
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Apr 25, 2024
@dotnet-bot
Copy link
Collaborator Author

⚠ This PR has merge conflicts. @dibarbet

Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@dotnet-policy-service dotnet-policy-service bot added the Needs API Review Needs to be reviewed by the API review council label May 7, 2024
Copy link
Contributor

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

@Cosifne Cosifne assigned Cosifne and unassigned dibarbet May 7, 2024
@dotnet-bot dotnet-bot merged commit 531daab into release/dev17.9 May 7, 2024
5 checks passed
@Cosifne Cosifne removed Merge Conflicts There are merge conflicts with the base branch. Needs API Review Needs to be reviewed by the API review council labels May 7, 2024
@Cosifne Cosifne deleted the merges/release/dev17.8-to-release/dev17.9 branch May 7, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants