Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EnableCodeStyleSeverity instead of AnalysisLevel to control new diagnostic severity behavior #73843

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jun 4, 2024

  • Use built-in features for marking unnecessary code
  • Verify missing code style severity falls back to old behavior
  • Use EnableCodeStyleSeverity instead of AnalysisLevel to control new diagnostic severity behavior

Follow-up to #72238

@sharwell sharwell requested a review from a team as a code owner June 4, 2024 18:24
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 4, 2024
@sharwell sharwell changed the title Custom severity Expand testing for code style severity settings Jun 4, 2024
@sharwell sharwell changed the title Expand testing for code style severity settings Use EnableCodeStyleSeverity instead of AnalysisLevel to control new diagnostic severity behavior Jun 4, 2024
@cremor
Copy link

cremor commented Jun 5, 2024

@sharwell
Copy link
Member Author

sharwell commented Jun 5, 2024

Yes, those would need to be updated. We'll also need to update the SDK code style build targets to feed the new build property to the compiler.

@arkalyanms arkalyanms requested a review from jaredpar July 16, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants