-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix android failed build #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming the files work on Android)
It looks like these added certs are still using RC2 for encryption, which is not supported on Android. We need these
The
|
I added new commit,
|
I just realized that the versions of |
I'm wondering if we should make the noRC2 simply the default rather than creating separate files. |
cc @bartonjs for thoughts on noRC2/RC2 as the default for cert test data |
We probably want to keep some in X509Certificates, since that's how Windows XP generated PFXes (and everyone else copied that behavior), but outside X509 it's not important... they can all be 3DES so long as they open everywhere. |
I'll remove all *.noRC2.pfx and replace *.pfx with triple des. |
@elinor-fung can you please verify the current version fulfil your requirements? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that we can load these on Android. Thanks, @aik-jahoda!
Add certificates needed for android build.
Follow up for dotnet/runtime#50230
cc @elinor-fung