Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials fix #50230

Merged
merged 14 commits into from
Mar 26, 2021
Merged

Credentials fix #50230

merged 14 commits into from
Mar 26, 2021

Conversation

aik-jahoda
Copy link
Contributor

@aik-jahoda aik-jahoda commented Mar 25, 2021

Replaces credentials and re-password certificates.

port of #50120

@ghost
Copy link

ghost commented Mar 25, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaces credentials and re-password certificates.

Author: aik-jahoda
Assignees: -
Labels:

area-System.Net

Milestone: -

@ghost
Copy link

ghost commented Mar 25, 2021

Hello @danmoseley!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@danmoseley
Copy link
Member

Failures are
#50271
#50270
and the xunit bug.

@danmoseley danmoseley merged commit 78f9803 into dotnet:main Mar 26, 2021
@aik-jahoda aik-jahoda deleted the jajahoda/cred-6.0 branch March 26, 2021 07:40
@elinor-fung
Copy link
Member

With this change, platforms that don't support RC2 (currently only Android, bring-up still in progress) now try to use non-existent certificate files:

string contosoPfxSuffix = PlatformSupport.IsRC2Supported ? ".pfx" : ".noRC2.pfx";
byte[] serverCertificateBytes = File.ReadAllBytes(Path.Combine(TestDataFolder, $"testservereku.contoso.com{contosoPfxSuffix}"));
byte[] clientCertificateBytes = File.ReadAllBytes(Path.Combine(TestDataFolder, $"testclienteku.contoso.com{contosoPfxSuffix}"));
byte[] noEKUCertificateBytes = File.ReadAllBytes(Path.Combine(TestDataFolder, $"testnoeku.contoso.com{contosoPfxSuffix}"));

Those files were added in dotnet/runtime-assets#120 and consumed in #49461. It looks like they were not included in dotnet/runtime-assets#124.

@aik-jahoda could you get those certs included in all this credentials re-passwording / suppression work? Or point us at what needs to happen here?

cc @jkoritzinsky @steveisok

@aik-jahoda
Copy link
Contributor Author

@elinor-fung there is a fix in runtime assets: dotnet/runtime-assets#128, I will change package version in runtime once the PR is merged and package published.

dougbu added a commit to dotnet/extensions that referenced this pull request Apr 8, 2021
dougbu added a commit to dotnet/extensions that referenced this pull request Apr 8, 2021
dougbu added a commit to dotnet/extensions that referenced this pull request Apr 8, 2021
- inspired by dotnet/runtime#50230
- cherry-picked from 1594096
dougbu added a commit to dotnet/extensions that referenced this pull request Apr 8, 2021
@aik-jahoda
Copy link
Contributor Author

the runtime now uses the fixed certificates: #51049

ghost pushed a commit to dotnet/extensions that referenced this pull request Apr 21, 2021
* Update branding to 2.1.27 (#3842)

* Update branding to 2.1.27

* Fix patchconfig, baseline val

* Update SDK and baseline

* [release/2.1] Update branding to 2.1.28 (#3855)

* Update branding to 2.1.28

* Bump incoming package patch versions
- e.g. `$(MicrosoftNETCoreAppPackageVersion)`
- updated xunit.assert and xunit.extensibility.execution minor versions
    - align with xunit package version

* Use Ubuntu 18.04 build agents
- set locale consistently on all platforms
    - default locale on newer agents is unloved `C.UTF-8`

* !flaky fix! Double compaction timeouts

* [release/2.1] Credentials fix (#3859)

- inspired by dotnet/runtime#50230
- cherry-picked from 1594096

* [release/2.1] Bump some versions (#3866)

* Move to latest KoreBuild / .NET SDK

* Update baselines
- did not ship any C# packages in 2.1.27
- re-enable baseline validation

* Bump Microsoft.NETCore.App package version

Co-authored-by: William Godbe <wigodbe@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Co-authored-by: Sebastien Ros <sebastienros@gmail.com>
ghost pushed a commit to dotnet/extensions that referenced this pull request May 5, 2021
* Update branding to 2.1.27 (#3842)

* Update branding to 2.1.27

* Fix patchconfig, baseline val

* Update SDK and baseline

* [release/2.1] Update branding to 2.1.28 (#3855)

* Update branding to 2.1.28

* Bump incoming package patch versions
- e.g. `$(MicrosoftNETCoreAppPackageVersion)`
- updated xunit.assert and xunit.extensibility.execution minor versions
    - align with xunit package version

* Use Ubuntu 18.04 build agents
- set locale consistently on all platforms
    - default locale on newer agents is unloved `C.UTF-8`

* !flaky fix! Double compaction timeouts

* [release/2.1] Credentials fix (#3859)

- inspired by dotnet/runtime#50230
- cherry-picked from 1594096

* [release/2.1] Bump some versions (#3866)

* Move to latest KoreBuild / .NET SDK

* Update baselines
- did not ship any C# packages in 2.1.27
- re-enable baseline validation

* Bump Microsoft.NETCore.App package version

* Update branding to 2.1.29 (#3870)

Co-authored-by: William Godbe <wigodbe@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants