Move test with expected crash to outerloop (#65114)

dotnet · Feb 11, 2022 · 77d6833 · 77d6833
1 parent 8160c23
commit 77d6833
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/eng/testing/RunnerTemplate.sh b/eng/testing/RunnerTemplate.sh
@@ -132,11 +132,7 @@ if [[ "$(uname -s)" == "Darwin" ]]; then
   # files already in /cores/ at this point. This is being done to prevent
   # inadvertently flooding the CI machines with dumps.
   if [[ ! -d "/cores" || ! "$(ls -A /cores)" ]]; then
-    # TODO: Re-enable core dumps - https://github.com/dotnet/runtime/issues/65000
-    # Temporarily disabling core dumps on osx as runtime work items uploading dumps
-    # are affecting the entire queue
-    # ulimit -c unlimited
-    ulimit -c 0
+    ulimit -c unlimited
   fi
 
 elif [[ "$(uname -s)" == "Linux" ]]; then

diff --git a/...ropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs b/...ropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs
@@ -159,13 +159,20 @@ void CreateDanglingRegistration()
             }
         }
 
+        [ConditionalFact(nameof(NotMobileAndRemoteExecutable))]
+        [OuterLoop("SIGQUIT will generate a coredump")]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/65000", TestPlatforms.OSX)] // large (~6 GB) coredump on OSX leads to timeout on upload
+        public void SignalCanCancelTermination_ExpectedCrash()
+        {
+            SignalCanCancelTermination(PosixSignal.SIGQUIT, false, 131);
+        }
+
         [ConditionalTheory(nameof(NotMobileAndRemoteExecutable))]
         [InlineData(PosixSignal.SIGINT, true, 0)]
         [InlineData(PosixSignal.SIGINT, false, 130)]
         [InlineData(PosixSignal.SIGTERM, true, 0)]
         [InlineData(PosixSignal.SIGTERM, false, 143)]
         [InlineData(PosixSignal.SIGQUIT, true, 0)]
-        [InlineData(PosixSignal.SIGQUIT, false, 131)]
         public void SignalCanCancelTermination(PosixSignal signal, bool cancel, int expectedExitCode)
         {
             // Mono doesn't restore and call SIG_DFL on SIGQUIT.