Skip to content

Commit

Permalink
[mono] Remove active issues for #57506 (#73492)
Browse files Browse the repository at this point in the history
* Remove active issues for  #57506

* Remove AssemblyInfo.cs references
  • Loading branch information
lewing committed Aug 15, 2022
1 parent 042f25f commit 8be2105
Show file tree
Hide file tree
Showing 12 changed files with 1 addition and 28 deletions.
2 changes: 0 additions & 2 deletions src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,12 @@ namespace System.Net.Tests
{
using Configuration = System.Net.Test.Common.Configuration;

[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public sealed class HttpWebRequestTest_Async : HttpWebRequestTest
{
public HttpWebRequestTest_Async(ITestOutputHelper output) : base(output) { }
protected override Task<WebResponse> GetResponseAsync(HttpWebRequest request) => request.GetResponseAsync();
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public sealed class HttpWebRequestTest_Sync : HttpWebRequestTest
{
public HttpWebRequestTest_Sync(ITestOutputHelper output) : base(output) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
using Xunit;

[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
[assembly: SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on Browser")]
[assembly: SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on Browser")]

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
Link="CommonTest\System\Security\Cryptography\PlatformSupport.cs" />
<Compile Include="$(CommonTestPath)System\Security\Cryptography\SignatureSupport.cs"
Link="CommonTest\System\Security\Cryptography\SignatureSupport.cs" />
<Compile Include="AssemblyInfo.cs" />
<Compile Include="Certificates.cs" />
<Compile Include="CertLoader.cs" />
<Compile Include="CertLoader.Settings.cs" />
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

namespace System.Security.Cryptography.X509Certificates.Tests.CertificateCreation
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static class CertificateRequestChainTests
{
public static bool PlatformSupportsPss { get; } = DetectPssSupport();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace System.Security.Cryptography.X509Certificates.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static class ChainTests
{
private static bool TrustsMicrosoftDotComRoot
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,6 @@ public static void X509CertificateCollectionCopyTo()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static void X509ChainElementCollection_CopyTo_NonZeroLowerBound_ThrowsIndexOutOfRangeException()
{
using (var microsoftDotCom = new X509Certificate2(TestData.MicrosoftDotComSslCertBytes))
Expand Down Expand Up @@ -1302,7 +1301,6 @@ public static void X509Certificate2CollectionGetHashCode()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static void X509ChainElementCollection_IndexerVsEnumerator()
{
using (var microsoftDotCom = new X509Certificate2(TestData.MicrosoftDotComSslCertBytes))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

namespace System.Security.Cryptography.X509Certificates.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static class DynamicChainTests
{
private static X509Extension BasicConstraintsCA => new X509BasicConstraintsExtension(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ public static void FindByValidThumbprint_ValidOnly(bool validOnly)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
[SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "Root certificate store is not accessible")]
public static void FindByValidThumbprint_RootCert()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
</PropertyGroup>
<Import Project="$(CommonPath)System\Security\Cryptography\Asn1Reader\System.Security.Cryptography.Asn1Reader.Shared.projitems" />
<ItemGroup>
<Compile Include="AssemblyInfo.cs" />
<Compile Include="$(CommonPath)System\Memory\PointerMemoryManager.cs"
Link="Common\System\Memory\PointerMemoryManager.cs" />
<Compile Include="$(CommonPath)System\Security\Cryptography\CryptoPool.cs"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,6 @@ public static void OpenMachineRootStore_Permissions(OpenFlags permissions, bool
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
[SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "Root certificate store is not accessible")]
public static void MachineRootStore_NonEmpty()
{
Expand Down

0 comments on commit 8be2105

Please sign in to comment.