Crypto and Networking tests failing on Linux Mariner when running on Mono. #57506
Labels
Milestone
Comments
dotnet-issue-labeler
bot
added
area-System.Net.Http
untriaged
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThere are a bunch of tests failing when running on Mono in Linux Mariner. It seems like all these tests share this common call: Some examples: System.Net.Tests.HttpWebRequestTest_Async.Headers_GetResponseHeaders_ContainsExpectedValue(useSsl: True)System.Security.Cryptography.X509Certificates.Tests.CertificateCreation.CertificateRequestChainTests.CreateChain_Hybridcc: @akoeplinger @steveisok @bartonjs
|
akoeplinger
removed
the
untriaged
|
related to #56478 ? That one is Mono only as well. |
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThere are a bunch of tests failing when running on Mono in Linux Mariner. It seems like all these tests share this common call: Some examples: System.Net.Tests.HttpWebRequestTest_Async.Headers_GetResponseHeaders_ContainsExpectedValue(useSsl: True)System.Security.Cryptography.X509Certificates.Tests.CertificateCreation.CertificateRequestChainTests.CreateChain_Hybridcc: @akoeplinger @steveisok @bartonjs
|
37 tasks
|
https://helix.dot.net/ only talks about mariner.2, but says mariner.1 (and there's no pipeline using mariner.2 that I see) so I'm not entirely sure the right way to go about clearing the ActiveIssue label here. But, having said that.That was with re-enabling all of the disabled tests: diff --git a/src/libraries/System.Net.Security/tests/FunctionalTests/AssemblyInfo.cs b/src/libraries/System.Net.Security/tests/FunctionalTests/AssemblyInfo.cs
index 68b152e1c3b..9adf9f8c835 100644
--- a/src/libraries/System.Net.Security/tests/FunctionalTests/AssemblyInfo.cs
+++ b/src/libraries/System.Net.Security/tests/FunctionalTests/AssemblyInfo.cs
@@ -5,5 +5,4 @@
using Xunit;
[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
-[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
-[assembly: SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on Browser")]
\ No newline at end of file
+[assembly: SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on Browser")]
diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/AssemblyInfo.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/AssemblyInfo.cs
index d338fa7711a..4eb4b982016 100644
--- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/AssemblyInfo.cs
+++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/AssemblyInfo.cs
@@ -5,4 +5,3 @@
using System;
using Xunit;
-[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/57810", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs
index 614ae070496..bf0b9e230a1 100644
--- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs
+++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs
@@ -11,7 +11,6 @@
namespace System.Security.Cryptography.X509Certificates.Tests
{
- [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static class ChainTests
{
private static bool TrustsMicrosoftDotComRoot
diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs
index df5c022b9fc..73c00e0dd43 100644
--- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs
+++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs
@@ -886,7 +886,6 @@ public static void X509CertificateCollectionCopyTo()
}
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))]
- [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static void X509ChainElementCollection_CopyTo_NonZeroLowerBound_ThrowsIndexOutOfRangeException()
{
using (var microsoftDotCom = new X509Certificate2(TestData.MicrosoftDotComSslCertBytes))
@@ -1302,7 +1301,6 @@ public static void X509Certificate2CollectionGetHashCode()
}
[Fact]
- [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static void X509ChainElementCollection_IndexerVsEnumerator()
{
using (var microsoftDotCom = new X509Certificate2(TestData.MicrosoftDotComSslCertBytes))
diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs
index c90b43d5243..489298ea58e 100644
--- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs
+++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs
@@ -12,7 +12,6 @@
namespace System.Security.Cryptography.X509Certificates.Tests
{
- [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static class DynamicChainTests
{
private static X509Extension BasicConstraintsCA => new X509BasicConstraintsExtension(
diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/FindTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/FindTests.cs
index 4abcce87bc5..a734da8b711 100644
--- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/FindTests.cs
+++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/FindTests.cs
@@ -231,7 +231,6 @@ public static void FindByValidThumbprint_ValidOnly(bool validOnly)
}
[Fact]
- [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
[SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "Root certificate store is not accessible")]
public static void FindByValidThumbprint_RootCert()
{
diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/RevocationTests/AiaTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/RevocationTests/AiaTests.cs
index 89882f4de5a..88cf0c20b8c 100644
--- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/RevocationTests/AiaTests.cs
+++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/RevocationTests/AiaTests.cs
@@ -8,7 +8,6 @@
namespace System.Security.Cryptography.X509Certificates.Tests.RevocationTests
{
- [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
[SkipOnPlatform(TestPlatforms.Android, "Android does not support AIA fetching")]
public static class AiaTests
{
diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/X509StoreTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/X509StoreTests.cs
index c63d118117b..a10c0f48a44 100644
--- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/X509StoreTests.cs
+++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/X509StoreTests.cs
@@ -426,7 +426,6 @@ public static void OpenMachineRootStore_Permissions(OpenFlags permissions, bool
}
[Fact]
- [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
[SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "Root certificate store is not accessible")]
public static void MachineRootStore_NonEmpty()
{So whatever the crashes were, they're gone now... at least on current mariner.2 |
|
I think not would be OK to remove the active issue if we run on Mariner.2. |
lewing
added a commit
to lewing/runtime
that referenced
this issue
Aug 15, 2022
lewing
added a commit
that referenced
this issue
Aug 15, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There are a bunch of tests failing when running on Mono in Linux Mariner.
It seems like all these tests share this common call:
Internal.Cryptography.Pal.ChainPal.BuildChainwhich then calls into openssl. The weird thing is that it only happens with Mono.Some examples:
System.Net.Tests.HttpWebRequestTest_Async.Headers_GetResponseHeaders_ContainsExpectedValue(useSsl: True)
System.Security.Cryptography.X509Certificates.Tests.CertificateCreation.CertificateRequestChainTests.CreateChain_Hybrid
cc: @akoeplinger @steveisok @bartonjs
The text was updated successfully, but these errors were encountered: