Skip to content

Commit

Permalink
[mono][sgen] Remove outdated assertion (#83824)
Browse files Browse the repository at this point in the history
objects_pinned is incremented when we fail to promote an object from nursery due to lack of memory. A long time ago, the concurrent collector was only scanning major objects, while the nursery objects were promoted from a separate nursery collection done also during the finishing pause. This is no longer the case as the finishing concurrent collection directly promotes objects from the nursery, having similar behavior to a normal blocking collection.
  • Loading branch information
BrzVlad committed Mar 24, 2023
1 parent dae6c24 commit 915ad08
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/mono/mono/sgen/sgen-gc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2331,8 +2331,6 @@ major_finish_collection (SgenGrayQueue *gc_thread_gray_queue, const char *reason
SGEN_ASSERT (0, sgen_workers_all_done (), "Can't have workers working after joining");

if (objects_pinned) {
g_assert (!sgen_concurrent_collection_in_progress);

/*
* This is slow, but we just OOM'd.
*
Expand Down

0 comments on commit 915ad08

Please sign in to comment.