[mono][sgen] Remove outdated assertion #83824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objects_pinned is incremented when we fail to promote an object from nursery due to lack of memory. A long time ago, the concurrent collector was only scanning major objects, while the nursery objects were promoted from a separate nursery collection done also during the finishing pause. This is no longer the case as the finishing concurrent collection directly promotes objects from the nursery, having similar behavior to a normal blocking collection.
|
Tagging subscribers to this area: @BrzVlad Issue Detailsobjects_pinned is incremented when we fail to promote an object from nursery due to lack of memory. A long time ago, the concurrent collector was only scanning major objects, while the nursery objects were promoted from a separate nursery collection done also during the finishing pause. This is no longer the case as the finishing concurrent collection directly promotes objects from the nursery, having similar behavior to a normal blocking collection. Fixes #83817
|
This was referenced Mar 23, 2023
vargaz
approved these changes
Mar 23, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objects_pinned is incremented when we fail to promote an object from nursery due to lack of memory. A long time ago, the concurrent collector was only scanning major objects, while the nursery objects were promoted from a separate nursery collection done also during the finishing pause. This is no longer the case as the finishing concurrent collection directly promotes objects from the nursery, having similar behavior to a normal blocking collection.
Fixes #83817