TestOnExecuteCustomCommand fails with Assert.Equal

[trylek]

Platform: Windows_NT x64/x86 Release
Pipeline: runtime-libraries outerloop
Example builds:

• https://dev.azure.com/dnceng/public/_build/results?buildId=482386
• https://dev.azure.com/dnceng/public/_build/results?buildId=481223
• https://dev.azure.com/dnceng/public/_build/results?buildId=483118

Proximate diagnostic info:

  Starting:    System.ServiceProcess.ServiceController.Tests (parallel test collections = on, max threads = 2)
    System.ServiceProcess.Tests.ServiceBaseTests.TestOnExecuteCustomCommand [FAIL]
      Assert.Equal() Failure
      Expected: 128
      Actual:   129
      Stack Trace:
        /_/src/libraries/System.ServiceProcess.ServiceController/tests/ServiceBaseTests.cs(156,0): at System.ServiceProcess.Tests.ServiceBaseTests.TestOnExecuteCustomCommand()
  Finished:    System.ServiceProcess.ServiceController.Tests
=== TEST EXECUTION SUMMARY ===
   System.ServiceProcess.ServiceController.Tests  Total: 22, Errors: 0, Failed: 1, Skipped: 0, Time: 23.417s

[danmoseley]

Usually those pass, most skip unless you’re elevated , and those are all failing: #1262

[jaredpar]

@danmosemsft it's failing on the last three outerloop builds. Updated the issue to link to the builds. Seems 100% at this moment.

[danmoseley]

@Anipik owns this test

[Anipik]

I will try to take look at this by the end of this week

[ericstj]

@danmosemsft it looks like you regressed it with #1234.

runtime/src/libraries/System.ServiceProcess.ServiceController/tests/ServiceBaseTests.cs

Lines 146 to 155 in e92e2e6

	// Response from test service:
	// 128 => Environment.UserInteractive == false
	// 129 => Environment.UserInteractive == true
	//
	// On Windows Nano and other SKU that do not expose Window Stations, Environment.UserInteractive
	// will always return true, even within a service process.
	// Otherwise, we expect it to be false.
	// (This is the only place we verify Environment.UserInteractive can return false)
	byte expected = PlatformDetection.HasWindowsShell ? (byte)128 : (byte)129;
	Assert.Equal(expected, _testService.GetByte());

[danmoseley]

Assert.Equal() Failure\r\nExpected: 128\r\nActual: 129

This means that PlatformDetection.HasWindowsShell is true in the test process (ie., IsWindows && IsNotWindowsServerCore && IsNotWindowsNanoServer && IsNotWindowsIoTCore;) which is expected...

but Environment.UserInteractive is true in the test service, which is not

        protected override void OnCustomCommand(int command)
        {
            base.OnCustomCommand(command);

            if (Environment.UserInteractive) // see ServiceBaseTests.TestOnExecuteCustomCommand()
                command++;

The failure is across Windows 7, Server, and Windows 8.1 - so it's not some special Windows SKU that needs special treatment like Nano.

This would be the case if corelib did not have my change, but the tests did -- could easily happen in the old two-repo system, but hopefully not possible any more.

Well, it's disabled for now. I'll have a look later, if @Anipik doesn't see the problem as part of #1262

[danmoseley]

I did run the tests locally of course -- although it's possible somehow in all the failures caused by #1262 I missed this one was not passing.

I also did test that Envirohment.UserInteractive returned false in a test service I made by hand and ran on Windows 10, and true on a Nano container.

[vatsan-madhavan]

Please take a look at dotnet/wpf#2663. WPF's OpenFileDialog is broken because Environment.UserInteractive is returning False all the time.

I don't think WinForms is broken though. I tried it and it seems to work fine.

[ericstj]

Looking at the intial commit that added this fuctionality I think the logic is inverted. #1234 (comment)

I'll submit a fix.

[antonfirsov]

Happened again in #47230, seems to fail multiple times a day according to kusto.
https://dev.azure.com/dnceng/public/_build/results?buildId=961825&view=ms.vss-test-web.build-test-results-tab&runId=30306908&resultId=104397&paneView=debug