Invert Environment.UserInteractive (fix) #32947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsan-madhavan
approved these changes
Feb 27, 2020
|
Fixed #32929 also, unless you want to track reverting the WPF workaround. |
Anipik
approved these changes
Feb 28, 2020
|
Hello @Anipik! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
stephentoub
approved these changes
Feb 28, 2020
ghost
merged commit 
|
I don’t think we’ll need to revert the wpf workaround - we just won’t merge the p1 branch into master. @rladuca that sound ok to you? |
Yep, we'll be fine for P1 as is and master will just begin to work correctly. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1724
When porting this the condition was inverted. Fix by correcting the condition and re-enabling the test.