Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows x86] InlinedCallFrame popping during EH corrupts Frame chain #2240

Closed
jkotas opened this issue Jan 27, 2020 · 1 comment · Fixed by #2215
Closed

[Windows x86] InlinedCallFrame popping during EH corrupts Frame chain #2240

jkotas opened this issue Jan 27, 2020 · 1 comment · Fixed by #2215
Assignees
@janvorli
Labels
area-ExceptionHandling-coreclr
Milestone
5.0.0

Comments

@jkotas
Copy link
Member

jkotas commented Jan 27, 2020

From #1929 (comment)

The problem is in the Windows x86 path here: https://github.com/dotnet/coreclr/pull/24199/files#diff-5eb922d9071dbbd2c84a9fa5f4468ea0R1880

We are missing a check like this: https://github.com/dotnet/coreclr/pull/24199/files#diff-d5e4cb27da3539140a16dc576906b925R1857

It results into unwinding too many Frames that sometime leads to asserts about corrupted Frame chain and crashes.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 27, 2020
@jkotas
Copy link
Member Author

jkotas commented Jan 27, 2020

I am adding a workaround for this issue in #1929. The workaround should be removed as part of the fix.

@jkotas jkotas mentioned this issue Jan 27, 2020
Merged
jkotas added a commit to clamp03/runtime that referenced this issue Jan 27, 2020
@jkotas
Add workaround for dotnet#2240
b4a3cc7
jkotas added a commit that referenced this issue Jan 28, 2020
@clamp03 @jkotas
Convert AssemblyNative::Load to QCall (#1929)
4011572 
* Convert AssemblyNative::Load to QCall

- FCall uses libunwind to find Method description.
- Get rid of the libunwind overhead in AssemblyNative::Load
  by converting to QCall

* Add workaround for #2240

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@jeffschwMSFT jeffschwMSFT added this to the 5.0 milestone Jan 30, 2020
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Jan 30, 2020
This was referenced Aug 28, 2020
Closed
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@janvorli janvorli

Labels
area-ExceptionHandling-coreclr
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix x86 InlinedCallFrame popping during EH janvorli/runtime
4 participants
@jkotas @jeffschwMSFT @janvorli @Dotnet-GitSync-Bot