This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Port fix for InlinedCallFrame corruption to 3.1 #28090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffschwMSFT
added
the
Servicing-consider
janvorli
approved these changes
Aug 31, 2020
jamshedd
added
Servicing-approved
|
Approved for the October 3.1.9 update. |
|
@jamshedd when should I check this in? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue discovered in the 5.0 timeframe where we would sometimes pop InlinedCallFrames of still active methods during a catch block. It was fixed in dotnet/runtime#2240, this ports the fix to 3.1.
Customer Impact
External customers reported a crash under the debugger in dotnet/runtime#41125, which was root caused to the same issue as dotnet/runtime#2240. The customer has verified that the fix for dotnet/runtime#2240 fixes the crash they are seeing.
Regression?
No
Risk (see taxonomy)
Low
Link the PR to the original issue and/or the PR to master.
dotnet/runtime#2240
Packaging impact? (if a libraries change)
None