Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Linq.Expressions tests are broken in CI #51346

Closed
eerhardt opened this issue Apr 15, 2021 · 6 comments · Fixed by #53782
Closed

System.Linq.Expressions tests are broken in CI #51346

eerhardt opened this issue Apr 15, 2021 · 6 comments · Fixed by #53782
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI disabled-test The test is disabled in source code against the issue
Milestone
6.0.0

Comments

@eerhardt
Copy link
Member 

C:\h\w\A918093D\w\A6DD0962\e>"C:\h\w\A918093D\p\dotnet.exe" exec --runtimeconfig System.Linq.Expressions.Tests.runtimeconfig.json --depsfile System.Linq.Expressions.Tests.deps.json xunit.console.dll System.Linq.Expressions.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Linq.Expressions.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Linq.Expressions.Tests (found 5645 of 5657 test cases)
  Starting:    System.Linq.Expressions.Tests (parallel test collections = on, max threads = 2)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableULongTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   9223372036854775808
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11459,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableULong(Single value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3128,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableULongTest(Boolean useInterpreter)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableULongTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   9223372036854775808
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9533,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableULong(Double value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1686,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableULongTest(Boolean useInterpreter)
    System.Linq.Expressions.Tests.ConvertTests.ConvertNullableDoubleToNullableULongTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   9223372036854775808
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9904,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyNullableDoubleToNullableULong(Nullable`1 value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1938,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertNullableDoubleToNullableULongTest(Boolean useInterpreter)
    System.Linq.Expressions.Tests.ConvertTests.ConvertNullableFloatToNullableULongTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   9223372036854775808
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11830,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyNullableFloatToNullableULong(Nullable`1 value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3380,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertNullableFloatToNullableULongTest(Boolean useInterpreter)
  Finished:    System.Linq.Expressions.Tests
=== TEST EXECUTION SUMMARY ===
   System.Linq.Expressions.Tests  Total: 35230, Errors: 0, Failed: 4, Skipped: 0, Time: 29.861s
@eerhardt eerhardt added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Apr 15, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Linq.Expressions untriaged New issue has not been triaged by the area owner labels Apr 15, 2021
@ghost
Copy link

ghost commented Apr 15, 2021

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details 
C:\h\w\A918093D\w\A6DD0962\e>"C:\h\w\A918093D\p\dotnet.exe" exec --runtimeconfig System.Linq.Expressions.Tests.runtimeconfig.json --depsfile System.Linq.Expressions.Tests.deps.json xunit.console.dll System.Linq.Expressions.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Linq.Expressions.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Linq.Expressions.Tests (found 5645 of 5657 test cases)
  Starting:    System.Linq.Expressions.Tests (parallel test collections = on, max threads = 2)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableULongTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   9223372036854775808
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11459,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableULong(Single value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3128,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableULongTest(Boolean useInterpreter)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableULongTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   9223372036854775808
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9533,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableULong(Double value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1686,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableULongTest(Boolean useInterpreter)
    System.Linq.Expressions.Tests.ConvertTests.ConvertNullableDoubleToNullableULongTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   9223372036854775808
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9904,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyNullableDoubleToNullableULong(Nullable`1 value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1938,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertNullableDoubleToNullableULongTest(Boolean useInterpreter)
    System.Linq.Expressions.Tests.ConvertTests.ConvertNullableFloatToNullableULongTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   9223372036854775808
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11830,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyNullableFloatToNullableULong(Nullable`1 value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3380,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertNullableFloatToNullableULongTest(Boolean useInterpreter)
  Finished:    System.Linq.Expressions.Tests
=== TEST EXECUTION SUMMARY ===
   System.Linq.Expressions.Tests  Total: 35230, Errors: 0, Failed: 4, Skipped: 0, Time: 29.861s
Author: eerhardt
Assignees: -
Labels:

area-System.Linq.Expressions, blocking-clean-ci, untriaged
Milestone: -

@eerhardt eerhardt added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-System.Linq.Expressions labels Apr 15, 2021
@eerhardt
Copy link
Member Author

Pinging the authors of the latest changes in src\coreclr:

@kunalspathak @SingleAccretion @davidwrighton @MichalStrehovsky @BruceForstall @trylek @jkoritzinsky

@runfoapp runfoapp bot mentioned this issue Apr 15, 2021
Closed
@eerhardt eerhardt mentioned this issue Apr 15, 2021
Merged
@SingleAccretion
Copy link
Contributor

Sigh. This is caused by #50450 - we are now folding the cases when float/double -> ulong conversions occur (previously they went through the helper path and weren't being folded) and this test is exercising some implementation-defined casts:

runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs

Line 3126 in 79ad10c

foreach (float value in new float[] { 0, 1, -1, float.MinValue, float.MaxValue, float.Epsilon, float.NegativeInfinity, float.PositiveInfinity, float.NaN })

It has the same root cause as #47374, and the fix is blocked by resolving #47478.

I will put up a PR to disable these for now.

@eerhardt I assume the log you have contains all the failures, right?

@eerhardt
Copy link
Member Author

I assume the log you have contains all the failures, right?

I think so.

@SingleAccretion SingleAccretion mentioned this issue Apr 15, 2021
Merged
@benaadams benaadams mentioned this issue Apr 15, 2021
Merged
@JeremyKuhne JeremyKuhne mentioned this issue Apr 16, 2021
Merged
@eerhardt eerhardt mentioned this issue Apr 16, 2021
Merged
@tannergooding tannergooding mentioned this issue Apr 16, 2021
Merged
@GrabYourPitchforks GrabYourPitchforks mentioned this issue Apr 16, 2021
Merged
@sandreenko sandreenko mentioned this issue Apr 16, 2021
Merged
@MihaZupan MihaZupan mentioned this issue Apr 16, 2021
Merged
@tannergooding tannergooding mentioned this issue Apr 16, 2021
Closed
@stephentoub stephentoub added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Apr 16, 2021
@akoeplinger akoeplinger mentioned this issue Apr 16, 2021
Merged
@ericstj ericstj mentioned this issue Apr 16, 2021
Merged
13 tasks
@SingleAccretion SingleAccretion mentioned this issue Apr 17, 2021
Merged
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Apr 20, 2021
@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Apr 20, 2021
SingleAccretion added a commit to SingleAccretion/runtime that referenced this issue Jun 6, 2021
@SingleAccretion
Re-enable tests disabled against dotnet#51346
74103e1
@AndyAyersMS
Copy link
Member

@SingleAccretion going to assign this to you. Let me know if you're not able to get to this sometime in the next week or two.

@SingleAccretion
Copy link
Contributor

I have a PR up that will re-enable these tests: #53782. I will switch it as ready-for-review.

@SingleAccretion SingleAccretion mentioned this issue Jun 7, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 7, 2021
kunalspathak pushed a commit that referenced this issue Jul 7, 2021
@SingleAccretion
Disable folding of implementation-defined casts (#53782)
527e566 
* Enhance the FloatOvfToInt2 test to exercise VN paths

It is not very effective right now because the "bad" combinations of
types are morphed into helpers too early, but it will be helpful when
we enable folding outside of the importer for those cases too.

* Enhance the FloatOvfToInt2 test to cover importer

It now fails on Windows x86, where many of the
previous similar failures were observed.

* Disable the test on Mono

* Re-enable tests disabled against #13651

* Re-enable tests disabled against #51346

* Re-enable tests disabled against #47374

* Disable folding in gtFoldExprConst

* Disable folding in VN

* Temporarily promote the test to Pri0

* Reword the comment

* Move the tests back to Pri1

Where they originally were.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2021
@SingleAccretion SingleAccretion removed their assignment Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Disable folding of implementation-defined casts SingleAccretion/runtime
5 participants
@stephentoub @eerhardt @AndyAyersMS @SingleAccretion @JulieLeeMSFT