Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecessary casting in SslStreamPal #51324

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Apr 15, 2021

Can pass a more strongly typed sealed derived type in.

@ghost
Copy link

ghost commented Apr 15, 2021

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: benaadams
Assignees: -
Labels:

area-System.Net.Security

Milestone: -

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is green, LGTM

@benaadams
Copy link
Member Author

If CI is green, LGTM

Will need to rerun after this is fixed #51346

@benaadams
Copy link
Member Author

Lot of weird failures on runtime-staging 🤔

@stephentoub stephentoub reopened this Apr 17, 2021
@marek-safar marek-safar merged commit ccc47f5 into dotnet:main Apr 19, 2021
@benaadams benaadams deleted the SslStream-casting branch April 19, 2021 14:41
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants