Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superpmi: add Extensions page to superpmi-replay pipeline to surface failures #66067

Open
BruceForstall opened this issue Mar 2, 2022 · 2 comments
Open

superpmi: add Extensions page to superpmi-replay pipeline to surface failures #66067

BruceForstall opened this issue Mar 2, 2022 · 2 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@BruceForstall
Copy link
Member

BruceForstall commented Mar 2, 2022 •
edited
Loading

superpmi-diffs, Antigen, and Fuzzlyn use the AzDO "Extensions" page functionality to surface interesting summary information about a run.

superpmi-replay should add an "Extensions" page to surface any assertions that occur during a run, to make them easy to find. This could start as simply "greping" for "" text.

category:eng-sys
theme:super-pmi
skill-level:beginner
cost:small
impact:small
@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 2, 2022
@BruceForstall BruceForstall added this to the Future milestone Mar 2, 2022
@ghost
Copy link

ghost commented Mar 2, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

superpmi-asmdiffs, Antigen, and Fuzzlyn use the AzDO "Extensions" page functionality to surface interesting summary information about a run.

superpmi-replay should add an "Extensions" page to surface any assertions that occur during a run, to make them easy to find. This could start as simply "greping" for "" text.

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: Future

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 2, 2022
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Mar 2, 2022
@BruceForstall BruceForstall mentioned this issue Mar 2, 2022
Merged
AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Mar 6, 2022
@AndyAyersMS
JIT: fix scalability issue in redundant branch optimizer
f529b43 
In methods with long skinny dominator trees and lots of redundant branches
the jit can spend too much time trying to optimize the branches.

Place a limit on the number of redundant branches with matching VNs that
the jit will consider for a given branch.

Fixes dotnet#66067.
@AndyAyersMS AndyAyersMS mentioned this issue Mar 6, 2022
Merged
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Mar 6, 2022
@BruceForstall
Copy link
Member Author

This shouldn't have been closed.

@BruceForstall BruceForstall reopened this Mar 7, 2022
github-actions bot pushed a commit that referenced this issue May 6, 2022
@AndyAyersMS
JIT: fix scalability issue in redundant branch optimizer
ab76be2 
In methods with long skinny dominator trees and lots of redundant branches
the jit can spend too much time trying to optimize the branches.

Place a limit on the number of redundant branches with matching VNs that
the jit will consider for a given branch.

Fixes #66067.
carlossanlop pushed a commit that referenced this issue May 14, 2022
@github-actions @AndyAyersMS
JIT: fix scalability issue in redundant branch optimizer (#68972)
3743f5e 
In methods with long skinny dominator trees and lots of redundant branches
the jit can spend too much time trying to optimize the branches.

Place a limit on the number of redundant branches with matching VNs that
the jit will consider for a given branch.

Fixes #66067.

Co-authored-by: Andy Ayers <andya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@BruceForstall